kochkinaelena / branchLSTM

branchLSTM model from Turing at SemEval-2017 Task 8: Sequential Approach to Rumour Stance Classification with Branch-LSTM
MIT License
22 stars 3 forks source link

Tidy up depth analysis script #3

Closed LouiseABowler closed 6 years ago

LouiseABowler commented 6 years ago

depth_analysis.py is used to generate the results in Tables 3-5 of the paper.

Names of some files have changed since the script was prepared, and the output could do with some editing so that the format more closely resembles that of the paper.

LouiseABowler commented 6 years ago

Initial tasks were:

  1. Update filenames.
  2. Make output more closely resemble the format of tables in the paper.
  3. Remove hardcoded best trial number.
  4. Add further functionality to examine the hyperparameter optimisation in more detail.

These have been completed in the following commits:

  1. db94f788703fe139588854486e72a08571eea806
  2. Table 3: 2d42dfbc3fe29cf691fd26fad6a7d6a46a048243 6be510955d4c8d730266009d207f04e636367f45 Table 4: 8d765b404e5522955b2cc7ea46f443670b2c9a90 edd717fc06854515ee51d21bbd656c4ef23feb37 Table 5: abdcaf36b016d54b5a816c2be1dd744efa1b1621
  3. 47767b4ba994a4fbef9bd77d3ffe35326c7d2ff1
  4. f8eecf0b60a84bb720c528180486cdf6b0d24476 33c5f2e5ba7624b3d1fb9da0762dff197c298748 cdc937f846626ec17de4fc0e27755ed5ed368c53

And I've found another couple of things I'd like to edit before closing this issue:

One other point to investigate further is that in the example I was testing, several sets of hyperparameters achieved the same optimal value. To do - check whether the "best" hyperparameter set is chosen consistently on different machines.

LouiseABowler commented 6 years ago

I've finished the other points I added to the previous comment, so I think this issue is ready to be closed after the pull request unless there are any other suggestions for improvements to the output.

I've made a couple of edits to preprocessing.py to combine the functionality of load_dataset() and the similar stage from the depth analysis script - tree2branches() is now called in the loading stage rather than when the tweets are processed later in the script.

LouiseABowler commented 6 years ago

Closed by 7e0c80e6a513ee613ec552c7d0cc34b3073bb766.