kochlisGit / ProphitBet-Soccer-Bets-Predictor

ProphitBet is a Machine Learning Soccer Bet prediction application. It analyzes the form of teams, computes match statistics and predicts the outcomes of a match using Advanced Machine Learning (ML) methods. The supported algorithms in this application are Neural Networks, Random Forests & Ensembl Models.
MIT License
286 stars 104 forks source link

Error pushing changes. The requested URL returned error: 403 #13

Open tiwiex opened 1 year ago

tiwiex commented 1 year ago

Hello, Thiis a great program and I have run a test. I was wondering if you allow contributions. I made two changes but effort to push gives an error.

I get a warning in nn.py that val_acc is deprecated in python 3.9. I am not sure of 3.8 though. I made the change and the problem has gone away. I was also thinking if I add any new leagues successfully, it would be great to share with the community.

Is there a restriction on pushing code back to the repo? Error is: remote: Permission to kochlisGit/ProphitBet-Soccer-Bets-Predictor.git denied to tiwiex. fatal: unable to access 'https://github.com/kochlisGit/ProphitBet-Soccer-Bets-Predictor.git/': The requested URL returned error: 403

Just want to be sure I am not doing something wrong.

Regards, Taiwo

tiwiex commented 1 year ago

Forked it and made a pull request. Thanks. I think that should be good enough.

kochlisGit commented 1 year ago

Thanks a lot. I will check the pull-request and get back to you soon!

From: Taiwo @.> Sent: Saturday, February 25, 2023 7:22 PM To: @.> Cc: @.***> Subject: [kochlisGit/ProphitBet-Soccer-Bets-Predictor] Error pushing changes. The requested URL returned error: 403 (Issue #13)

Hello, Thiis a great program and I have run a test. I was wondering if you allow contributions. I made two changes but effort to push gives an error.

I get a warning in nn.py that val_acc is deprecated in python 3.9. I am not sure of 3.8 though. I made the change and the problem has gone away. I was also thinking if I add any new leagues successfully, it would be great to share with the community.

Is there a restriction on pushing code back to the repo? Error is: remote: Permission to kochlisGit/ProphitBet-Soccer-Bets-Predictor.git denied to tiwiex. fatal: unable to access 'https://github.com/kochlisGit/ProphitBet-Soccer-Bets-Predictor.git/': The requested URL returned error: 403

Just want to be sure I am not doing something wrong.

Regards, Taiwo

— Reply to this email directly, view it on GitHubhttps://github.com/kochlisGit/ProphitBet-Soccer-Bets-Predictor/issues/13, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALUJURAIAWADF2KUWSU5I7DWZI5WDANCNFSM6AAAAAAVH63HJY. You are receiving this because you are subscribed to this thread.Message ID: @.***>

kochlisGit commented 1 year ago

Hello, Thanks for contributing to ProphitBet. I really appreciate your help. I have some comments about your changes.

  1. val_acc is replaced by val_accuracy indeed, but it is still supported for older version of tensorflow, that’s why I think it should be left as it is for now!
  2. The russian league should be an “extra”, not “main” league in the “available_leagues.csv” file, because It is included in the “extra” category! Another way to separate the leagues is by url. “main” leagues include multiple csv files (e.g. 2012, 2013, 2014, etc.), one for each season, whereas “extra” leagues include only once csv with all seasons.

From: Taiwo @.> Sent: Saturday, February 25, 2023 8:57 PM To: @.> Cc: @.***> Subject: Re: [kochlisGit/ProphitBet-Soccer-Bets-Predictor] Error pushing changes. The requested URL returned error: 403 (Issue #13)

Forked it and made a pull request. Thanks. I think that should be good enough.

— Reply to this email directly, view it on GitHubhttps://github.com/kochlisGit/ProphitBet-Soccer-Bets-Predictor/issues/13#issuecomment-1445182186, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALUJURGNQ2RNDC2RCBAG5EDWZJI3DANCNFSM6AAAAAAVH63HJY. You are receiving this because you are subscribed to this thread.Message ID: @.***>