search

kockie69 / SquinkyVCV-main

GNU General Public License v3.0
24 stars 13 forks source link

Fix logging related warnings #19

Closed RareBreeds closed 3 years ago

RareBreeds commented 3 years ago

Removed the first "" from the SQINFO arguments. A new __FUNCTION__ argument was added to the Rack2 logger, adding the "" to the Squinky logger caused the number of arguments to match, so it compiled and passed "" as the function name, but the correct fix I think is to update the SQINFO macro so that __FUNCTION__ is passed.

Fixed all logging related warnings on Ubuntu and Windows.

The only warning I see now is the following, which is in the Rack v2 code base:

../../include/engine/Module.hpp:216:21: warning: unused variable ‘br’ [-Wunused-variable]
kockie69 commented 3 years ago

Thank you, I know my fix was a dirty one, but needed it back as one of the modules was using it to display messages. Wanted to pick up later, but thanks again!