kockie69 / SquinkyVCV-main

GNU General Public License v3.0
22 stars 12 forks source link

Feature Request: Envelope on the Kitchen Sink #36

Closed mosesve closed 2 years ago

mosesve commented 2 years ago

So, here is my second idea for the kitchen sink.

Replacing the envelope of the kitchen sink with a triggerable DAHD(S)RE-Envelope.

Most of the time in VCV there will be some kind of sequencer triggering the envelopes of kitchen sink with a fixed gate-length, unless you are using some of the more advanced sequencers which have the option to define a gate-length or playing it via a keyboard. In that context I don't think a normal ADSR-Envelope will be used to its full potential. I studied the implementation of envelopes in a few hardware and software fm synthesizers and what I found was quiet interesting. The keyboard-style FM-Synth Korg OPSIX for example uses normal ADSR-Envelopes, whereas the sequencer-style synths like the elektron digitone or the app drambo in iOS (powerful modular sequencer and synth) uses some kind of triggerable Envelopes with the option of a sustain-phase. So my idea for the optimal Envelope for an FM-Operator would be an Delay(time), Attack(time), Hold(time), Decay(Time), optional Sustain(level), Release(time), End(level) - Envelope. I know that is a very sophisticated approach to an envelope and most likely enough stuff for a single module, but any triggerable subset of the listed parameters would be also great to have. For example an Attack(time)-Decay(time)-End(level) envelope with an optional sustain/hold stage. As long as it runs through a full cycle when triggered. The Bogaudio DADSR(H) comes close but misses out on the end-level, which is imho important for an FM-Operator.

Just my 2 cents of input, thanks for reading it,

Kind regards,

mo

kockie69 commented 2 years ago

Thank you for the idea and I will have a look at it. My thoughts for now are I will create such an envelope as a standalone module under my RPJ brand and enhance Kitchensick with that code afterwards. I will keep you updated on the progress.

kockie69 commented 2 years ago

I think we can close this one now isn't it? Now that you can use whatever Envelope you want?

mosesve commented 2 years ago

Yes, of course. This one is obsolete with the new Module.