kockie69 / SquinkyVCV-main

GNU General Public License v3.0
22 stars 12 forks source link

Undo doesn't work in multiple cases #70

Open RareBreeds opened 2 years ago

RareBreeds commented 2 years ago

I was following this topic https://community.vcvrack.com/t/how-to-implement-undo-feature/17730 and tried out the Seq++ undo behavior and it doesn't seem to work correctly. I noticed a few issues in Seq++ and across other modules in the plugin.

I'm using a builds from source on macOS plugin - d482868 Rack - v2.1.1

squinkylabs commented 1 year ago

Do you really think "run" should be undoable? Is there any module where "run" is undoable?

squinkylabs commented 1 year ago

btw, the dropdown does undo, but it doesn't readraw it's state after undo. I got a fix for that somewhere, @kockie69 is welcome to have it.

squinkylabs commented 1 year ago

Interesting log entry:

error getting module in undo
error getting module in undo
squinkylabs commented 1 year ago

I submitted some pull requests - one for the undo breaking in VCV 2.0, and the other to make the drop-downs undo correctly. So hopefully fixes will be coming soon.