kockie69 / SquinkyVCV-main

GNU General Public License v3.0
24 stars 13 forks source link

Seq++ note input bug #75

Open glend1 opened 2 years ago

glend1 commented 2 years ago

adding notes with mouse can be a little buggy.

I currently have grid settings set to quarter notes and snap to grid enabled, when I double click to enter a note on the second half of a subdivision it will add a note to the next subdivision. double clicking just left of the green bar will result in the green bar showing image

if you start with a short note and try to override the note with a longer note before the short note you end up generating a second note stacked on top of the note. I don't think it changes the output of the module, but it does confuse how the module operates. image

squinkylabs commented 2 years ago

I would think with the settings you have (quarter note, snap to grid) that what you are seeing is exactly "correct" - it's inserting on the nearest quarter note. It sounds like you don't really want it to snap to a quarter note. Something like a 1/16 note might be more reasonable.

glend1 commented 2 years ago

my point being is that there are two notes overlapping each other in the time line, this is not standard to the daw interface and i think its not intended to behave this way for seq++

squinkylabs commented 2 years ago

ah, yes, I get it. I don't know if there is any code in there to try and prevent overlapped notes. What would your preference be? that inserting new notes delete any old notes that are under them?

fwiw - note editing via the mouse is fairly weak - it's much, much, much easier with the keyboard commands.

glend1 commented 2 years ago

i think it would be better if new notes overwrote old notes

kockie69 commented 2 years ago

This fix can be tested now. Download available from here: https://github.com/kockie69/SquinkyVCV-main/actions/runs/2925132217