search

kocsismate / php-di-container-benchmarks

Benchmark for some popular PHP Dependency Injection Containers.
https://kocsismate.github.io/php-di-container-benchmarks/benchmark.html
MIT License
76 stars 26 forks source link

Add ProxyAutoloader to Disco config #14

Closed shochdoerfer closed 7 years ago

shochdoerfer commented 7 years ago

By configuring the proxy autoloader Disco will not re-generate the cache files on every request.

kocsismate commented 7 years ago

Thank your for the quick PR! I am curious how much it improves Disco's performance!

Anyway, I prefer to put compiled containers in the "resource" directories in the repo because it is easier to analyze them like that. Would you mind if I changed the path of the generated container for Disco too?

shochdoerfer commented 7 years ago

Sure, not a problem. Go ahead. The change improved the performance a lot, using the stored configuration helps even more. But somehow the results seem a bit random. Need to dig into the why a bit more.

kocsismate commented 7 years ago

Do you run the tests with Docker? Unfortunately, with Docker for Mac they also seemed to be random for me too, so I had to install PHP-FPM on my host machine. This way, results are much more in line to what I supposed.

shochdoerfer commented 7 years ago

Yes I did run the tests in Docker. Good to know that this might be "problematic" ;)

kocsismate commented 7 years ago

Yeah, it is a bit sad thing to learn :/ I will try to use another image, and in the worst case, update the read me :D

kocsismate commented 7 years ago

But in any case, it's good to see that the new config improved Disco's performance a lot!