kodadot / nft-gallery

Generative Art Marketplace
https://kodadot.xyz
MIT License
595 stars 346 forks source link

fix: New Profile creation/editing better field validation/error handling #10169

Closed Jarsen136 closed 2 weeks ago

Jarsen136 commented 2 weeks ago

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

Needs QA check

Context

goes after #10140

Did your issue had any of the "$" label on it?

Screenshot 📸

Kapture 2024-04-30 at 13 02 46

image
netlify[bot] commented 2 weeks ago

Deploy Preview for koda-canary ready!

Name Link
Latest commit 5261de60790ba7d4ca22f93f3d0b5d1faaec28b5
Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/66338f8e9e01b5000819c3a4
Deploy Preview https://deploy-preview-10169--koda-canary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

daiagi commented 2 weeks ago

@Jarsen136

Ive changed base branch

This allows to focus on your changes more clearly

Base branch will automatically change to main after the other pr is merged and it's branch deleted

Jarsen136 commented 2 weeks ago

Base branch will automatically change to main after the other pr is merged and it's branch deleted

Thanks, that's good.

prury commented 2 weeks ago

thank you very much @Jarsen136

daiagi commented 2 weeks ago

@prury why close?

prury commented 2 weeks ago

@prury why close?

it was automatic, i did not clicked on close

daiagi commented 2 weeks ago

openinig

prury commented 2 weeks ago

openinig

i think jarsen has to change branch to main and reopen

daiagi commented 2 weeks ago

i think jarsen has to change branch to main and reopen

indeed

i can't seem to change the base branch

daiagi commented 2 weeks ago

open

daiagi commented 2 weeks ago

open

daiagi commented 2 weeks ago

@Jarsen136

I've resolved merge conflicts for you https://github.com/kodadot/nft-gallery/pull/10169/commits/434b418ecfe9eede4bd6fb29c72ea070d1eb1a21

hope you don't mind

Jarsen136 commented 2 weeks ago

@Jarsen136

I've resolved merge conflicts for you 434b418

hope you don't mind

Thanks, never mind.

It looks like github would not automatically handle the case of the base branch change.

daiagi commented 2 weeks ago

@Jarsen136 somehow it did work for me very well recently

I'm guessing it's because I was branching a pr off of my own branches

Screenshot_2024-04-30-21-20-56-83_320a9a695de7cdce83ed5281148d6f19.jpg

codeclimate[bot] commented 2 weeks ago

Code Climate has analyzed commit 5261de60 and detected 0 issues on this pull request.

View more on Code Climate.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud