search

kodadot / nft-gallery

Generative Art Marketplace
https://kodadot.xyz
MIT License
595 stars 346 forks source link

roll out Profile-V3 #10176

Closed daiagi closed 2 weeks ago

daiagi commented 2 weeks ago

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

Needs QA check

Context

Did your issue had any of the "$" label on it?

netlify[bot] commented 2 weeks ago

Deploy Preview for koda-canary ready!

Name Link
Latest commit d37233a4f7eb80f02df6b1c7eed8ab305b5c0179
Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6633a32a06f14e0008607f85
Deploy Preview https://deploy-preview-10176--koda-canary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

prury commented 2 weeks ago

i'll handle the failing tests

prury commented 2 weeks ago

maybe remove the buynow=false at the end: image

prury commented 2 weeks ago

other than the above, works for me, i have added some small visual bugs on visual PR

daiagi commented 2 weeks ago

other than the above, works for me, i have added some small visual bugs on visual PR

Fixed. Thank you :)

codeclimate[bot] commented 2 weeks ago

Code Climate has analyzed commit d37233a4 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

daiagi commented 2 weeks ago

@prury

merge conflicts are already resolved