:technologist: max mint per hdd is one :) - Githubissues

kodadot / nft-gallery

Generative Art Marketplace

https://kodadot.xyz

MIT License

595 stars 346 forks source link

:technologist: max mint per hdd is one :) #10182

Closed vikiival closed 2 weeks ago

vikiival commented 2 weeks ago

Why

as free drops does not work, we are not using holder of and we do not have implemented max_per_user

as per - https://github.com/kodadot/ops-internal/issues/1611

I set max mint for 1 so in case someone wants to mint all it will be a bit hard from the UI :)

fix(drops): limit tilescapes drop to max 4 pieces
:wrench: set maxmint of hdd to 1

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

(please remove design and QA checks below if not needed)

Needs Design check

@exezbcz please review

Needs QA check

@kodadot/qa-guild please review

Context

[ ] Closes #
[ ] Requires deployment <worker/stick/speck>

Before submitting pull request, please make sure:

[ ] My contribution builds clean without any errors or warnings
[ ] I've merged recent default branch -- main and I've no conflicts
[ ] I've tried to respect high code quality standards
[ ] I've didn't break any original functionality

Optional

[ ] I've tested it at </ahp/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Did your issue had any of the "$" label on it?

[ ] Fill up your DOT address: Payout

Community participation

[ ] Are you at Koda Ecosystem Telegram?

Screenshot 📸

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

netlify[bot] commented 2 weeks ago

Deploy Preview for koda-canary ready!

Name	Link
Latest commit	be477792391737980d04d2cffd49b0a87d9d7028
Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/663380468834dd0008f6dca9
Deploy Preview	https://deploy-preview-10182--koda-canary.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codeclimate[bot] commented 2 weeks ago

Code Climate has analyzed commit be477792 and detected 0 issues on this pull request.

View more on Code Climate.

vikiival commented 2 weeks ago

I have cherry-picked @hassnian's - #10076