kodadot / nft-gallery

Generative Art Marketplace
https://kodadot.xyz
MIT License
614 stars 351 forks source link

Make existential deposit limits more user-friendly #10198

Open JustLuuuu opened 2 months ago

JustLuuuu commented 2 months ago

Issue

Screenshot 2024-05-03 at 10 27 41 Screenshot 2024-05-03 at 10 27 30

Solution

Problem two

hassnian commented 2 months ago

we need to make existential deposit limits more clear anyone trying to buy NFT with ED should know why they cannot. this should be clear with all transactions - not only buying, but it needs to be clear with all transactions - burning, listing, selling...

cc @exezbcz

will we have that forever?

as mentioned here at this moment this is the only solution.

New users usually come to platform with 1-3 DOTs to test and play with it. And they cannot buy NFTs.

regarding EDs 1.5 DOT on polkadot and 0.5 DOT on ahp are only applied when doing teleports

if you have funds already in ahp the current ED is set to 0.01 DOT and polkadot 1 DOT, and these EDs are used when performing actions like minting, buying etc

at the moment looks like the transaction can happen but it will fail

I'm assuming the user had around 2.4 DOT , and was able to do one teleport and mint, the second time with 1.9 DOT. would go below our ED. worked as intended , so he wasn't able to sign that 's why he saw the add funds

@prury can you test this , users should not be able to sign the transaction if it goes below ED, thanks

JustLuuuu commented 2 months ago

I'm assuming the user had around 2.4 DOT , and was able to do one teleport and mint, the second time with 1.9 DOT. would go below our ED. worked as intended , so he wasn't able to sign that 's why he saw the add funds

Yeah and here is the problem. People coming from outside of Polkadot don't have any idea what ED is. They assume that its not working and there is an issue. In this case they should be able to see a message or info somewhere. For example, Your funds cannot go under existential deposit. Or something like that linked to hello. 😄

I mean, these are gen artists that are currently struggling; I believe if artists are struggling, users must be double confused.

prury commented 2 months ago
* @prury can you test how it is right now? how app reacts when people are trying to buy NFTs with ED?

it only shows add funds via onramp, without any info about ED.

@prury can you test this , users should not be able to sign the transaction if it goes below ED, thanks

tested and they are not able to go trough if transaction goes below ED

Yeah and here is the problem. People coming from outside of Polkadot don't have any idea what ED is. They assume that its not working and there is an issue. In this case they should be able to see a message or info somewhere. For example, Your funds cannot go under existential deposit. Or something like that linked to hello. 😄

on point Lu, transfer already has some information about ED, we need to put it on drops and in other places as well.

summoning @exezbcz to provide a design for it, be it a tooltip or a small text to be shown together with the add funds via on ramp modal and also inside the auto teleport modal.