Remove giant squid from the code

Jarsen136 commented 2 weeks ago

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

[x] Bugfix
[x] Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #10268
[x] Closes #10329
[x] Closes #10323

replace on-chain identity with profile data
remove giant squid request
remove the identity setting page completely
performance: batch request several profiles data in one request https://github.com/kodadot/private-workers/pull/156
Clean the console log for profile request https://github.com/kodadot/private-workers/pull/159
Introduce vue-query to better manage the request cache #https://github.com/kodadot/nft-gallery/discussions/10329
cache single profile request/profiles/:address` #10323
cache profiles list request/profiles?ids=string[] #10323
Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

netlify[bot] commented 2 weeks ago

Deploy Preview for koda-canary ready!

Name	Link
Latest commit	f757d47c13596475df2f97c135bd137a98792229
Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/664e01061b096f0008b58b9a
Deploy Preview	https://deploy-preview-10299--koda-canary.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Jarsen136 commented 2 weeks ago

Code Climate has analyzed commit bcce23e and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count Duplication 2 View more on Code Climate.

It's the wrong analysis from codeclimate. Let's ignore it.

prury commented 2 weeks ago

tests can be ignored as well, twitter changed itself to x

prury commented 2 weeks ago

i'm checking the other errors

prury commented 2 weeks ago

getting some different errors now:

daiagi commented 2 weeks ago

getting some different errors now:

not sure errors is the right word here

these profiles simply don't exist

Jarsen136 commented 2 weeks ago

getting some different errors now:

not sure errors is the right word here

these profiles simply don't exist

Yup. It's the expected response result with a 404 status code, so it's not a real "error".

However, if we would like to make the console look more clean without showing any request 404 code, I will simply change the 404 code to 200 and return null value. Only applied for API of /profile/:address because it should be called lots of times. In this way, we could "hide" the 404 request error from the console.

https://github.com/kodadot/private-workers/pull/159

Jarsen136 commented 1 week ago

getting some different errors now:

not sure errors is the right word here these profiles simply don't exist

Yup. It's the expected response result with a 404 status code, so it's not a real "error".

However, if we would like to make the console look more clean without showing any request 404 code, I will simply change the 404 code to 200 and return null value. Only applied for API of /profile/:address because it should be called lots of times. In this way, we could "hide" the 404 request error from the console.

kodadot/private-workers#159

✅ https://github.com/kodadot/private-workers/pull/159 Deployed and also removed the error log from the console

Jarsen136 commented 1 week ago

can benefit from caching

rest is kinda minor

Thanks! I have updated them.

daiagi commented 1 week ago

@Jarsen136 you may want to look at #10323

Jarsen136 commented 1 week ago

@Jarsen136 you may want to look at #10323

https://github.com/kodadot/nft-gallery/issues/10324 It could be done first.

Jarsen136 commented 1 week ago

@vikiival How about merging it ?

vikiival commented 1 week ago

Is it somehow cached?

Jarsen136 commented 1 week ago

Is it somehow cached?

It's already cached but not ideal. Ideally, It needs a better fetching library with cache. Should I implement it at the current PR also? https://github.com/kodadot/nft-gallery/discussions/10329

Jarsen136 commented 1 week ago

✅ Cache Handler

[x] Introduce vue-query to better manage the request cache #https://github.com/kodadot/nft-gallery/discussions/10329
[x] cache single profile request/profiles/:address` #10323
[x] cache profiles list request/profiles?ids=string[] #10323

socket-security[bot] commented 1 week ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/eslint-config-prettier@9.1.0	None	`0`	20.8 kB	lydell
npm/eslint-plugin-prettier@5.1.3	Transitive: environment	`+5`	243 kB	jounqin
npm/lodash@4.17.21	None	`0`	1.41 MB	bnjmnt4n
npm/prettier@3.2.5	environment, filesystem, unsafe	`0`	8.39 MB	prettier-bot
npm/prismjs@1.29.0	None	`0`	2.05 MB	rundevelopment
npm/three@0.164.1	None	`0`	21.9 MB	mrdoob
npm/typescript@5.4.5	None	`0`	32.4 MB	typescript-bot

🚮 Removed packages: npm/@dargmuesli/nuxt-cookie-control@7.5.1, npm/@farcaster/auth-client@0.1.1, npm/@fortawesome/fontawesome-svg-core@6.5.2, npm/@fortawesome/vue-fontawesome@3.0.6, npm/@google/model-viewer@3.5.0, npm/@histoire/plugin-vue@0.17.6, npm/@kodadot1/hyperdata@0.0.1-rc.4, npm/@kodadot1/minimark@0.1.14-rc.0, npm/@kodadot1/minipfs@0.4.3-rc.1, npm/@kodadot1/sub-api@0.3.1-rc.0, npm/@nuxt/content@2.12.1, npm/@nuxt/image@1.7.0, npm/@nuxt/types@2.17.3, npm/@nuxtjs/apollo@5.0.0-alpha.6, npm/@nuxtjs/color-mode@3.4.1, npm/@nuxtjs/device@3.1.1, npm/@nuxtjs/google-fonts@3.2.0, npm/@nuxtjs/i18n@8.3.1, npm/@nuxtjs/sitemap@5.1.5, npm/@oruga-ui/oruga-next@0.7.0, npm/@paraspell/sdk@5.2.1, npm/@pinia/nuxt@0.5.1, npm/@polkadot/api-base@10.13.1, npm/@polkadot/api@10.13.1, npm/@polkadot/apps-config@0.135.1, npm/@polkadot/extension-dapp@0.47.3, npm/@polkadot/extension-inject@0.47.3, npm/@polkadot/types@10.13.1, npm/@polkadot/ui-keyring@3.6.6, npm/@polkadot/ui-settings@3.6.6, npm/@polkadot/util-crypto@12.6.2, npm/@polkadot/util@12.6.2, npm/@polkadot/vue-identicon@3.6.6, npm/@ramp-network/ramp-instant-sdk@4.0.5, npm/@transak/transak-sdk@1.4.1, npm/@types/jest@27.5.2, npm/@types/lodash@4.17.1, npm/@types/markdown-it@13.0.8, npm/@types/node@20.12.11, npm/@typescript-eslint/eslint-plugin@6.21.0, npm/@typescript-eslint/parser@6.21.0, npm/@vite-pwa/nuxt@0.7.0, npm/@vitejs/plugin-vue@4.6.2, npm/@vitejs/plugin-vue@5.0.4, npm/@vitest/coverage-c8@0.33.0, npm/@vitest/coverage-istanbul@0.34.6, npm/@vueuse/core@9.13.0, npm/@vueuse/nuxt@9.13.0, npm/autoprefixer@10.4.19, npm/bulma@0.9.4, npm/changelogen@0.5.5, npm/chart.js@4.4.2, npm/chartjs-adapter-date-fns@3.0.0, npm/chartjs-plugin-zoom@2.0.1

View full report↗︎

socket-security[bot] commented 1 week ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source
Install scripts	npm/es5-ext@0.10.64	Install script: postinstall Source: `node -e "try{require('./_postinstall')}catch(e){}" \|\| exit 0`	orphan: npm/es5-ext@0.10.64
Protestware/Troll package	npm/es5-ext@0.10.64	Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale	orphan: npm/es5-ext@0.10.64
Install scripts	npm/esbuild@0.20.2	Install script: postinstall Source: `node install.js`	orphan: npm/esbuild@0.20.2

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package my come along with functionality unrelated to its primary purpose.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@SocketSecurity ignore npm/es5-ext@0.10.64
@SocketSecurity ignore npm/esbuild@0.20.2

prury commented 1 week ago

@Jarsen136 can you check socket security issues?

Jarsen136 commented 1 week ago

@Jarsen136 can you check socket security issues?

The issues it reported are not from this PR. I have no idea why it's warning here. Let's ignore it for now.

package in the code:

prury commented 1 week ago

@Jarsen136 can you check socket security issues?

The issues it reported are not from this PR. I have no idea why it's warning here. Let's ignore it for now.

strange indeed, thank you checking!