feat: Control return to confirm action

Jarsen136 commented 1 month ago

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

[x] Feature

Needs Design check

@exezbcz please review

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #10213

Did your issue had any of the "$" label on it?

[x] My DOT address: Payout

Screenshot 📸

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

netlify[bot] commented 1 month ago

Deploy Preview for koda-canary ready!

Name	Link
Latest commit	806c6245beb8ddd59f74a6d9f51ea56e33f769c3
Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/664e087472e29a00078cc88b
Deploy Preview	https://deploy-preview-10306--koda-canary.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

prury commented 4 weeks ago

bug or a feature :)

probably we should only allow that shortcut if the transaction has not started CleanShot.2024-05-16.at.17.18.47.mp4

can useMagicKeys combinations give you a cleaner solution?

thank you very much for checking it @hassnian

Jarsen136 commented 4 weeks ago

bug or a feature :)

probably we should only allow that shortcut if the transaction has not started

can useMagicKeys combinations give you a cleaner solution?

Thank you! I have updated it.

prury commented 4 weeks ago

What should be the correct behavior? working only for confirmation buttons on modals or also for trying again when a transaction is cancelled/fails?

Transfer: doesn't work on confirmation button prob because it uses a different modal Teleport bridge: works on try again Drop: works on modal and on try again Create NFT/Collection: won't proceed to signing if you hit it once, i think it's a focus issue, doesn't work on try again Buy Now: works for signing but doesn't for try again Listing: works for signing but doesn't for try again

Jarsen136 commented 3 weeks ago

What should be the correct behavior? working only for confirmation buttons on modals or also for trying again when a transaction is cancelled/fails?

I prefer it only works for confirmation buttons on modal.

Transfer: doesn't work on confirmation button prob because it uses a different modal

Yup, it's a separate modal. However, I have also made the transfer confirm modal work with the shortcut. Now it should work as the others.

Teleport bridge: works on try again Drop: works on modal and on try again Create NFT/Collection: won't proceed to signing if you hit it once, i think it's a focus issue, doesn't work on try again Buy Now: works for signing but doesn't for try again Listing: works for signing but doesn't for try again

Only applying to the confirm button should be enough. I can't manage to go to the page with "try again" button after I cancel the transaction request. It keeps loading all the time. I would leave it to another follow-up issue if anyone else could reproduce it and fix it.

Kapture 2024-05-20 at 01 03 48