Fix NeoButton - Githubissues

kodadot / nft-gallery

Generative Art Marketplace

https://kodadot.xyz

MIT License

602 stars 347 forks source link

Fix NeoButton #10314

Closed FG-HJ closed 2 weeks ago

FG-HJ commented 2 weeks ago

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

(please remove design and QA checks below if not needed)

Needs Design check

@exezbcz please review

Needs QA check

@kodadot/qa-guild please review

Context

[x] Closes #10267
[ ] Requires deployment <worker/stick/speck>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[ ] I've tested it at </ahp/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Did your issue had any of the "$" label on it?

[ ] Fill up your DOT address: Payout

Community participation

[ ] Are you at Koda Ecosystem Telegram?

Screenshot 📸

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

netlify[bot] commented 2 weeks ago

Deploy Preview for koda-canary ready!

Name	Link
Latest commit	4192d7e92ce87e85a19f5f8c8ef05d040ee5f5d4
Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6646654c1675200008d723f9
Deploy Preview	https://deploy-preview-10314--koda-canary.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codeclimate[bot] commented 2 weeks ago

Code Climate has analyzed commit 4192d7e9 and detected 0 issues on this pull request.

View more on Code Climate.

vikiival commented 2 weeks ago

Cc @hassnian can you please check?

daiagi commented 2 weeks ago

why is pnpm-lock file changed?