kodadot / nft-gallery

Generative Art Marketplace
https://koda.art
MIT License
634 stars 361 forks source link

App reports success on failed drop #11060

Open vikiival opened 12 hours ago

vikiival commented 12 hours ago

Context

after - #11059 I was shocked that app reported "minting successful"

Screenshot 2024-09-30 at 12 04 58

Fix

make sure that Error state is handled correctly as error

misc

maybe need design from @exezbcz

vikiival commented 12 hours ago

cc any from @kodadot/internal-dev

preschian commented 11 hours ago

seems like I put the toast in the wrong place

https://github.com/kodadot/nft-gallery/blob/3d2acdf04a44dd52b964f9d2ebc5820c6be9dabc/components/collection/drop/modal/shared/SuccessfulDrop.vue#L58-L59

preschian commented 11 hours ago

I was shocked that app reported "minting successful"

oohh, or maybe better should not render SuccessfulDrop.vue component instead

vikiival commented 11 hours ago

I was shocked that app reported "minting successful"

oohh, or maybe better should not render SuccessfulDrop.vue component instead

Yes there should be failed drop modal that's the reason I have tagged exez

Screenshot 2024-09-30 at 12 33 22

exezbcz commented 2 hours ago

yup, the error design toast template is here:

image

https://www.figma.com/design/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=9705-14201&node-type=canvas&t=JcYs8Js306ghf8bU-11

we can put a copy like that:

image

"Minting of the drop has failed due to a technical issue. Please try again later"