kodadot / nft-gallery

Generative Art Marketplace
https://koda.art
MIT License
645 stars 362 forks source link

✨ swap page landing #11163

Open roiLeo opened 1 month ago

roiLeo commented 1 month ago

Screenshot 2024-10-23 at 11-52-32 Swap NFTs One Stop Shop for Polkadot NFTs

netlify[bot] commented 1 month ago

Deploy Preview for koda-canary ready!

Name Link
Latest commit 8b80fdbfc7de58c02797fd22869461c4cbf1f71b
Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6735dd8ec3e38e0009561b74
Deploy Preview https://deploy-preview-11163--koda-canary.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

roiLeo commented 4 weeks ago

I see that the pr does not close the issue, do you want to finish it ? otherwise I can take over.

Yea it's WIP, feel free to take it if you need to ship it faster

use translation keys for all words

yes, that would be ideal

limit this page to only assethub inside redirect.global using getPermissionRouteCondition -> permission.config.ts if you are not logged this should be a button (I guess like the transfer page)

noted! ty

roiLeo commented 4 weeks ago

@hassnian any way to split the work? so we don't erase each other stuff like someone handle the logic, any other step or maybe you want full control?

hassnian commented 4 weeks ago

@hassnian any way to split the work? so we don't erase each other stuff like someone handle the logic, any other step or maybe you want full control?

yeah it's gonna be hard since its a lot of new code, I'll let you finish it. I can work on something else in the meantime

vikiival commented 4 weeks ago

Well how swap works:

So my recommendation is that one can start with item detail:

The Swap page (cc @exezbcz): On one side is your nft on the other is either desired nft or considered collection

It means if desired on the indexer is null you want nft from particular collection

Future You can additionally add surcharge which https://github.com/kodadot/stick/blob/39ac052e60cc0b9c03ca1d3e23cb6c3f869e5822/schema.graphql#L244

You can either send or receive

vikiival commented 4 weeks ago

However I like also your idea to invite a "conter-party" so you can easily look for "his/hers" nfts

hassnian commented 1 week ago

@roiLeo a08d281 I think we should not use bulma anymore , new code should only use tailwind since we have

wdyt?

roiLeo commented 1 week ago

@roiLeo a08d281 I think we should not use bulma anymore , new code should only use tailwind since we have

* [Bulma conflicting with Tailwind classes  #9973](https://github.com/kodadot/nft-gallery/issues/9973)

* [remove bulma css #9013](https://github.com/kodadot/nft-gallery/issues/9013)

wdyt?

sure i'll replace is-hidden-touch with tailwind equivalent, same goes for colums with grid/flex layout. I'm not too worried about Bulma, I'm more concerned with oruga UI.

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud