kodadot / nft-gallery

Generative Art Marketplace
https://koda.art
MIT License
634 stars 361 forks source link

Mitigation to support Ledger hardware wallet #218

Closed gre closed 2 months ago

gre commented 3 years ago

I've been able to use Ledger hardware wallet with the Kusama application in combination with Chrome's polkadot{.js} extension support.

It seems that this bug relates to limitation of the current Kusama Ledger nano app: the device does not fully support batching yet (it could happen in future, but still, signing huge things with a ledger will not be easily possible).

I was wondering if we could consider a mitigation on the web app side, ultimately it's a decision to bundle all operations or make multiple calls, and it could help Ledger hardware wallet support.

Thanks a lot, gre

vikiival commented 3 years ago

Hey, I would love to support Legder in KodaDot.

I was wondering if we could consider a mitigation on the web app side

Yeah you are right we would have to split operations into multiple transactions.

P.S. Is it possible to get a Ledgder testing unit?

vikiival commented 3 years ago

// Dev Looks like it is possible to detect origin of the account

vikiival commented 3 years ago

So v5.90 supports utility.batchAll however the latest app on Ledger Live is v5.30.1

Screenshot 2021-07-13 at 11 09 57
vikiival commented 3 years ago

cc @gre https://github.com/Zondax/ledger-kusama/issues/83#issuecomment-878993197

roiLeo commented 1 year ago