search

kodadot / nft-gallery

Generative Art Marketplace
https://kodadot.xyz
MIT License
605 stars 347 forks source link

KodaDot Explorer Upgrade #2650

Open XyloDrone opened 2 years ago

XyloDrone commented 2 years ago

To do

Done

You can check the design with all the above issues implemented here in V2_dark: Sidebar. https://www.figma.com/file/GeVzZKVORd9L8kAWrlKtZv/?node-id=0%3A1

prachi00 commented 2 years ago

@XyloDrone sure

roiLeo commented 2 years ago

Already (or partially) done

Backend stuff (https://github.com/kodadot/rubick)

Remainder

XyloDrone commented 2 years ago

Thanks for the info @roiLeo , I removed the tasks which are completed.

If something is a backend issue, do you guys need someone else to give a hand with these types of developments, is it more timely or..? :D

vikiival commented 2 years ago

If something is a backend issue

It means that we need to update our rubick indexer so we have the data for the NFT gallery

is it more timely or..? :D

Well it depends on the change:

XyloDrone commented 2 years ago

Thanks for the clarification @vikiival :D Is there any chance that #1367 could be sorted with a resolver? Artist have been vocal about this issue before and they stated how it messes up their profiles.

vikiival commented 2 years ago

Is there any chance that https://github.com/kodadot/nft-gallery/issues/1367 could be sorted with a resolver?

So the fast solution: we need to write a resolver that would return the same data https://github.com/kodadot/rubick/issues/19

The problem: We currently use magick for the artist profiles https://github.com/vikiival/magick/issues/11

The fix: I can write the query and resolver and if would someone would take it from there I would be super happy ❤️

XyloDrone commented 2 years ago

Thanks @vikiival :D @roiLeo any chance you can take this up from Viki once he has written the resolver :DDD Pretty please 👯 Or if there is someone else more suitable for such a quest feel free to reccommend them :3

Jarsen136 commented 2 years ago

Is there any chance that #1367 could be sorted with a resolver?

So the fast solution: we need to write a resolver that would return the same data kodadot/rubick#19

The problem: We currently use magick for the artist profiles vikiival/magick#11

The fix: I can write the query and resolver and if would someone would take it from there I would be super happy ❤️

Hi, I am willing to take it if you can help to write the resolver. @vikiival

vikiival commented 2 years ago

@XyloDrone with the help of SubSquid Guys we found a workaround

If @Jarsen136 wants to pick that up the whole setup is here https://github.com/kodadot/nft-gallery/issues/1367#issuecomment-1080601293

XyloDrone commented 2 years ago

Fab

yangwao commented 2 years ago

Added one we talked with @petersopko that merging collections under explorer together is easier for further maintenance which I really agree on

XyloDrone commented 2 years ago

@yangwao @petersopko I couldn't properly understand this, merging collections how? :D

XyloDrone commented 2 years ago

Anybody wanna pick up #1231 ? Seems quite important to easily find artists / collections if you know what you are looking for as a collector...

vikiival commented 2 years ago

Anybody wanna pick up https://github.com/kodadot/nft-gallery/issues/1231 ?

Looks like it was closed in favour of #2719

XyloDrone commented 2 years ago

I'd say these are 2 different matters.

1231 is the search engine; there will probably be users which know what they are looking for(nft/collection/artist) and they will want to easily find these... still missing easy search for artists... @roiLeo , u wanna grab it as you were commenting there? :DDD

Whilst #2719 is about browsing through artists/nfts/collections...seems like @prachi00 is on it :D

@Jarsen136 do you wanna grab the infinity scroll issues if there's nothing else on yer plate? #1582 + #1411

yangwao commented 2 years ago

Highlighting Search of meaning which sort of underlying functionality would benefit explorer expansion and search! Like literally family package 2in1 for a discounted price.

Jarsen136 commented 2 years ago

@Jarsen136 do you wanna grab the infinity scroll issues if there's nothing else on yer plate? #1582 + #1411

Personally, it seem very strange to have a pagination and infinite scroll at the same time. If we keep only one of them, I can have a try : )

XyloDrone commented 2 years ago

@yangwao @vikiival what do you guys think? I personally vote for infinity scroll, @cryptodamsky mentioned that some collectors asked in surveys for this option :D

yangwao commented 2 years ago

@Jarsen136 do you wanna grab the infinity scroll issues if there's nothing else on yer plate? #1582 + #1411

Personally, it seem very strange to have a pagination and infinite scroll at the same time. If we keep only one of them, I can have a try : )

problem with infinity scroll hard to address (shareable URL) where are "you" in "feed" but I guess if we figure out a way to tackle let's go, but in general, https://github.com/kodadot/nft-gallery/issues/1582 has video how alza.sk has it yup

okay let's go.

Jarsen136 commented 2 years ago

problem with infinity scroll hard to address (shareable URL) where are "you" in "feed" but I guess if we figure out a way to tackle let's go, but in general, #1582 has video how alza.sk has it yup

okay let's go.

I have some ideas to address (shareable URL) where are "you" in "feed" without pagination. Ok, I will have a try.

preschian commented 2 years ago

problem with infinity scroll hard to address (shareable URL) where are "you" in "feed" but I guess if we figure out a way to tackle let's go, but in general, #1582 has video how alza.sk has it yup okay let's go.

I have some ideas to address (shareable URL) where are "you" in "feed" without pagination. Ok, I will have a try.

Jarsen so cool 🚀

XyloDrone commented 2 years ago

GM @Jarsen136 any updates on the infinity scroll issue(s) :D

Jarsen136 commented 2 years ago

GM @Jarsen136 any updates on the infinity scroll issue(s) :D

GM. This issue seems a little bit complex. I will try to make a demo of the collection page in the next two days. : )

XyloDrone commented 2 years ago

No worries, take your time, looking forward to seeing it :D

yangwao commented 2 years ago

Seems Infinite scroll is being made here, with few hiccups but fair ready! https://github.com/kodadot/nft-gallery/pull/2859

XyloDrone commented 2 years ago

Anybody want to take the backend stuff so we can get some snazzy filters in? 👀 @Jarsen136 @roiLeo @kkukelka @petersopko ? 🚀

XyloDrone commented 2 years ago

Well done @Jarsen136 on the infinity scroll! 🥳

roiLeo commented 2 years ago

Anybody want to take the backend stuff so we can get some snazzy filters in? 👀 @Jarsen136 @roiLeo @kkukelka @petersopko ? 🚀

Thanks but I'll pass, it's not my field.

XyloDrone commented 2 years ago

Good to know, what’s your preference usually? Just so I know, I’m assuming front end? :D

roiLeo commented 2 years ago

Good to know, what’s your preference usually? Just so I know, I’m assuming front end? :D

Yup, frontend & design

petersopko commented 2 years ago

Anybody want to take the backend stuff so we can get some snazzy filters in? 👀 @Jarsen136 @roiLeo @kkukelka @petersopko ? 🚀

I'll take a look at some of the open subsquid tasks