Handle accounts with ss58 format more properly - Githubissues

kodadot / nft-gallery

Generative Art Marketplace

https://koda.art

MIT License

638 stars 360 forks source link

Handle accounts with ss58 format more properly #3019

Closed vikiival closed 2 months ago

vikiival commented 2 years ago

Is your feature request related to a problem?

With upcoming parachain implementations the problems with ss58 would rise :)

Describe the solution you would like

I would like to see some smart implementation how to solve issues like:

bad address
account equality

Describe alternatives you have considered

I have tried this alternative:

on the app level have a subscriber that would handle the address format
have middleware that would convert address from any ss58 format to correct one

Screeenshots

Screenshot 2022-05-14 at 13 59 32

yangwao commented 2 years ago

maybe fixed in one of these?

2857
3118
3121
2998

vikiival commented 2 years ago

This is marked as enhancment, not a bug

vikiival commented 2 months ago

Discussed in

https://github.com/kodadot/nft-gallery/discussions/4754