kodadot / nft-gallery

Generative Art Marketplace
https://koda.art
MIT License
638 stars 360 forks source link

Inspect cloudflare images #4625

Closed yangwao closed 1 year ago

yangwao commented 1 year ago

Well, on beta.kodadot.xyz seems worked, but I see there same issue as main domain

image

It seems image delivery doesn't work on kodadot.xyz

image

image

Probably I sense issue is at worker and cors?

If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

Ref

yangwao commented 1 year ago

@preschian seems we should disable cors on workers for now?

INteresting yesterday everything worked for me

preschian commented 1 year ago

the issue related with this one https://github.com/kodadot/nft-gallery/issues/4597 durable-jpeg sent back not exist id. we dont need id anymore, so the path can be replaced with cid

yangwao commented 1 year ago

yeah I see now, it's returning 404 for things which doesn't exists.

preschian commented 1 year ago

ok, let me adjust in some parts first. I will start from carousel first

preschian commented 1 year ago

adjust getCloudflareImageLinks usage related issue: https://github.com/kodadot/nft-gallery/issues/4597

preschian commented 1 year ago

this is for carousel https://github.com/kodadot/nft-gallery/pull/4626 will check another components

context: the issue was in some components still using old implementation image, which is call durable-jpeg to get cf id, which is getCloudflareImageLinks function. so the fix was adjust the component to use image proxy directly

preschian commented 1 year ago

1 left, on search components. still in progress

yangwao commented 1 year ago

@preschian thank you for quick fix!

yangwao commented 1 year ago

Thank you for your amazing and quick response! @holopin-bot @preschian

holopin-bot[bot] commented 1 year ago

Uh oh, there's something wrong with your config.

yangwao commented 1 year ago

Thank you for your amazing and quick response! @holopin-bot @yangwao