search

kodadot / nft-gallery

Generative Art Marketplace
https://kodadot.xyz
MIT License
602 stars 347 forks source link

Reduce using nuxt-property-decorator and use composition API #4750

Closed yangwao closed 9 months ago

yangwao commented 1 year ago

We need to reduce using nuxt-property-decorator first and use composition API instead. It will help us to migrate to vue3/nuxt3 https://github.com/nuxt-community/nuxt-property-decorator/issues/83#issuecomment-1245139696. at least for newer components related: https://github.com/kodadot/nft-gallery/issues/2893

And I think we face this problem also https://github.com/nuxt-community/nuxt-property-decorator/issues/83#issuecomment-1246615441; most of the library is still not ready in nuxt3. And maybe some libs/modules are not compatible also in nuxt-bridge

It seems we have a lot of them (484 mentions)

Part of

Originally posted by @preschian in https://github.com/kodadot/nft-gallery/issues/2690#issuecomment-1280409802

Ref

yangwao commented 1 year ago

It's improving!

465 code results in kodadot/nft-gallery

yangwao commented 1 year ago

456 code results

yangwao commented 1 year ago

415 code results in kodadot/nft-gallery

roiLeo commented 1 year ago

Can't manage to use layout() with nuxt-bridge..

edit: nuxt3 way

definePageMeta({
  layout: 'default'
})
yangwao commented 1 year ago

178 files

yangwao commented 1 year ago

162 👀

image

https://github.com/search?q=repo%3Akodadot%2Fnft-gallery+nuxt-property-decorator&type=code

yangwao commented 1 year ago

156 👀

image

I think lot of files can be deleted, we should have a look what we doesn't need migrate at all.

yangwao commented 1 year ago

144 files 👀

roiLeo commented 11 months ago

144 files .. again 🪨

yangwao commented 11 months ago

141 files 👀

yangwao commented 11 months ago

134 👀👀👀

yangwao commented 11 months ago

👀👀👀 125 👀 👀👀👀

yangwao commented 10 months ago

115 😏

yangwao commented 10 months ago

88 files 😳

yangwao commented 9 months ago

78 files 🤩

yangwao commented 9 months ago

63 files 🤯

yangwao commented 9 months ago

54 🫣

vikiival commented 9 months ago

34 🔢

yangwao commented 9 months ago

34 🔢

search shows 50, maybe cached?

vikiival commented 9 months ago

search shows 50, maybe cached?

Well yes and no

Number of .vue components

yangwao commented 9 months ago

It's moving 43 / 30

yangwao commented 9 months ago

35 / 24

yangwao commented 9 months ago

29 / 18

yangwao commented 9 months ago

26 / 15

yangwao commented 9 months ago

17 / 6

nuxt3 is getting closer you can vote on prediction market btw - https://app.zeitgeist.pm/markets/238

yangwao commented 9 months ago

13 / 2 and probably hitting 🏁 after

yangwao commented 9 months ago

Very last ~three~ two components.

yangwao commented 9 months ago

Last two?

vikiival commented 9 months ago

Very last ~three~ two components.

Time to update STYLE_GUIDE.md

And check if we use some of the last mixins

yangwao commented 9 months ago

12 / 1

vikiival commented 9 months ago

According Create component we do not use typescript mixins

yangwao commented 9 months ago

12 / 0 (it was cache)

yangwao commented 9 months ago

golf 1 par shot

yangwao commented 9 months ago

Done in