Composable-transactionMint

[daiagi]

Thank you for your contribution to the KodaDot NFT gallery.

👇 _ Let's make a quick check before the contribution.

PR Type

• [ ] Bugfix
• [ ] Feature
• [x] Refactoring

Context

• [x] Closes #5034
• [ ] Requires deployment <>

Before submitting pull request, please make sure:

• [x] My contribution builds clean without any errors or warnings
• [x] I've merged recent default branch -- main and I've no conflicts
• [x] I've tried to respect high code quality standards
• [x] I've didn't break any original functionality
• [ ] I've posted a screenshot of demonstrated change in this PR

Optional

• [ ] I've tested it at </bsx/collection>
• [x] tested by minting on snek and RMRK, with and without listing for sell
• [ ] I've tested PR on mobile
• [ ] I've written unit tests 🧪
• [ ] I've found edge cases

Had issue bounty label?

• [x] Fill up your KSM address: Payout

Community participation

• [ ] Are you at KodaDot Discord?

Screenshot 📸

• [ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

[kodabot]

WARNING @daiagi PR for issue #5034 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #5034

[netlify[bot]]

✅ Deploy Preview for koda-nuxt ready!

Name	Link
🔨 Latest commit	2740e9f6d0554168766b8172db94d9da641757e4
🔍 Latest deploy log	https://app.netlify.com/sites/koda-nuxt/deploys/64187d73b99a7b00084abbe7
😎 Deploy Preview	https://deploy-preview-5276--koda-nuxt.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[daiagi]

this PR covers minting Token composable Minting collection will follow in another PR

[vikiival]

Minting collection will follow in another PR

I would rather do this first

[vikiival]

Yeah sorry, closing that was a bit harsh. Sorry for that I just overreacted

I just rather do the collections first, it is much easier and 80% of pinning logic can be extracted away.

The reasoning is this is hard to review. Contains a lot of dupictated code.

[daiagi]

Yeah, it was challenging to write as well

I'll do the collection minting, sure

But as for this one, how about I split the files to make it easier read?

And there are actually no duplications In fact I've removed duplicate code

[vikiival]

But as for this one, how about I split the files to make it easier read?

Yes please decompose pinning from the file

I'll do the collection minting, sure

Yeah I think it's easier to do.

Sorry one more time for closing that 🙈

and thanks @roiLeo for reopening that

[roiLeo]

Hey! I don't want to interfere but I've just tested on snek (/snek/gallery/331660682-9) and for me it works very well. It's already a good start and it allows to get the logic out of the components (better readability). And that is what I asked when I've opened #5034. In any case it will be useful when we'll rewrite minting experence (and maybe massmint). Nice work, keep it up! 😉

[daiagi]

Hey! I don't want to interfere but I've just tested on snek (/snek/gallery/331660682-9) and for me it works very well. It's already a good start and it allows to get the logic out of the components (better readability). And that is what I asked when I've open #5034. In any case it will be useful when we'll rewrite minting experence (and maybe massmint). Nice work, keep it up! wink

Thanks @roiLeo Appreciate the positive feedback :smile:

[vikiival]

Wondering why are you refactoring SimpleMint instead of rmrk/CreateToken.vue ?

[vikiival]

But so far really good job 🤗

[daiagi]

Wondering why are you refactoring SimpleMint instead of rmrk/CreateToken.vue ?

I was working on CreateToken

simpleMint just one line change due to moving utils outside of rmrk folder

[vikiival]

[vikiival]

Looks like some failed checks

[daiagi]

Update: created composables for minting collection and use them in CreateCollection components

@roiLeo have a look once again please

[daiagi]

Looks like some failed checks

@vikiival they can be ignored because 1.

both these function will return for chains bsx, snek, rmrk, rmrk2, as needed, DeepSource complains that there isn't a return value outside of an if, and there shouldn't be

2.

this is about the signature of executeTransaction \ howAboutToExecute. I'm not gonna mess with it in this PR

[roiLeo]

Update: created composables for minting collection and use them in CreateCollection components

@roiLeo have a look once again please

Now same issue as #5266 (collectionId: 3124270296)

I saw somewhere that [[ Rare Waifu ]] was default fallback metadata

[daiagi]

Now same issue as #5266 (collectionId: 3124270296)

What chain? I'll double check.

[roiLeo]

Now same issue as #5266 (collectionId: 3124270296)

What chain? I'll double check.

/snek BLOCK 1827618

[daiagi]

ok so...

1. it happens when minting collection on snek in beta as well
2. I've tested the minting collection in this PR in RMRK and BSX, both works

so the issue does not stem from this PR

[damskyftw]

It currently doesn’t let me mint with KSM fee asset. Says "Insufficient funds" even tho i have enough :)

[daiagi]

It currently doesn’t let me mint with KSM fee asset. Says "Insufficient funds" even tho i have enough :)

Hey @helloitsdamsky Do I understand correctly that you tried on kusama network? Did you try minting a collection or NFT? does it work for you on beta?

Lastly, what account did you try with?

Thank you Possibly related with #5284

update: I've just tested minting collection and NFT on Kusama and Basilisk. I've encountered no issues

[daiagi]

tested again by minting collection and NFT on BSX and RMRK

• /bsx/collection/651189115
• /rmrk/collection/669DB118F2897C6014-PLN

[vikiival]

Can please @JustLuuuu or @helloitsdamsky test?

[daiagi]

/reviewpad summarize

[JustLuuuu]

Can please @JustLuuuu or @helloitsdamsky test?

If Im using the correct Deploy link for testing, it's still not working for me:

I have created a new wallet especially to test this while I was writing an article about minting on Basilisk. This account has exactly 0 bsx tokens. Only KSM (bridged). I believe even if you set KSM as a fee, it still somehow requires bsx. Test it with a wallet where you have 0 bsx.

When I tried to test it with a wallet where I had some bsx tokens. It worked.

[reviewpad[bot]]

This pull request includes various changes across multiple files. Changes involve new functions, types, and modifications to existing functions related to minting NFTs and collections. The execMintToken, execMintBasilisk, execMintCollection, execMintCollectionRmrk, useNewCollectionId, constructMeta, and useTransaction functions were added or modified. Various files such as CreateToken.vue, transactionMintCollection.ts, utils.ts, and notification.ts were also updated. Other changes include updates to import statements and regular expressions.

[daiagi]

I have created a new wallet especially to test this while I was writing an article about minting on Basilisk. This account has exactly 0 bsx tokens. Only KSM (bridged). I believe even if you set KSM as a fee, it still somehow requires bsx. Test it with a wallet where you have 0 bsx.

When I tried to test it with a wallet where I had some bsx tokens. It worked.

strongly suspect it has to do with this:

• https://github.com/kodadot/nft-gallery/issues/5284

[daiagi]

I had a chat with @JustLuuuu who confirmed minting on Kusama works I have also created PR #5305 to fix the minting with bridged KSM on Basilisk issue

[vikiival]

More like suggestions otherwise LGTM

[vikiival]

pay 100 usd

[yangwao]

😍 Perfect, I’ve sent the payout 💵 $100 @ 35.66 USD/KSM ~ 2.804 $KSM 🧗 EfmnRhHaQqfT3phm4cUCHCU3gFVDoSPR1U9WXzMRQBMqZ4L 🔗 0xc516fcda2389cb05b71352d71bcc3885de14deface541810ad216fbb1a4dc5ab

🪅 Let’s grab another issue and get rewarded! 🪄 github.com/kodadot/nft-gallery/issues

[codeclimate[bot]]

Code Climate has analyzed commit 2740e9f6 and detected 14 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	6
Duplication	8

View more on Code Climate.