kodadot / nft-gallery

Generative Art Marketplace
https://kodadot.xyz
MIT License
612 stars 351 forks source link

Collection edit UI #5286

Open exezbcz opened 1 year ago

exezbcz commented 1 year ago

we will have a new ui for editing/customizing collection for owners - mainly because introducing big banner on collection detail

Figma

Main

image

Icon

Banner

image

Social links

image

Save changes

I think we could maybe expand the options in future - something like name edit etc, but for now I think it works Thank you!

roiLeo commented 1 year ago

Wait.. I'm pretty sure it's not possible to edit/customize already minted collection. Once it's minted data is "frozen" on chain. (from what I understand on Bsx and Rmrkv1)

exezbcz commented 1 year ago

@roiLeo ah okay, and is it possible code it or is it just one of the specifications of those networks?

I think that for the social links we can store it off chain no? Or at least that is how opensea does it no?

Correct me if I am wrong Thanks!

roiLeo commented 1 year ago

@roiLeo ah okay, and is it possible code it or is it just one of the specifications of those networks?

networks specification that don't enable these features but I may be wrong I've seen it's possible to update some metadata part on eth.

I think that for the social links we can store it off chain no? Or at least that is how opensea does it no?

Hmm.. alright why not but it has a cost, we will need to maintain external database (off chain) I don't really like this solution because for me it goes against the chain and data will not persist as before. I'm still open to discussion if there is really a gain in displaying this data.

exezbcz commented 1 year ago

yes, understand. The banner on the collection that has different size than profile pic is why I did this customize ui. And also the social links - but not sure how to store it tho if its not possible to have it onchain for each collection - maybe @vikiival would know?

vikiival commented 1 year ago

Can push it to Supabase imo :D or mint is as metadata and push it to chain via system.remark

vikiival commented 1 year ago

But First we should make ability to upload banner on the collection

yangwao commented 1 year ago
vikiival commented 1 year ago

store one more pic on r2

You still need some way how to make refference for the picture πŸ˜‡

exezbcz commented 1 year ago

updated image

yangwao commented 1 year ago

You still need some way how to make refference for the picture πŸ˜‡

yeah, I was thinking for some off-chain config.json for collections till we will be putting it on-chain

yangwao commented 1 year ago

Time for some flex. Would be nice if we can have single service for fandoms as well if possible, wyt?

roiLeo commented 1 year ago

Time for some flex. Would be nice if we can have single service for fandoms as well if possible, wyt?

we should try to keep it on chain, maybe in Identity pallet

yangwao commented 1 year ago

we should try to keep it on chain

what's pro being on-chain for this?

Identity pallet has lot of limitations iirc.

roiLeo commented 1 year ago

what's pro being on-chain for this?

Identity pallet has lot of limitations iirc.

Yes, unfortunately. Imo we should first focus on #2329, and try to implement the rest something like an external db (but it would need secret keys, limit api usage...)

yangwao commented 1 year ago
  • can be reused across plateform (singular, fandom, kodadot etc..)

if it will be HTTP endpoint, how it differs?

try to implement the rest something like an external db (but it would need secret keys, limit api usage...)

I prefer off-chain first, quick iterations and then we can figure out on-chain, don't want to repeat dumb mistakes ala carte RMRK team 😎

exezbcz commented 1 year ago

Are any ui changes needed?

roiLeo commented 1 year ago

https://ethereum.stackexchange.com/a/103147

if it will be HTTP endpoint, how it differs?

CORS, domain validation, server maintenance

I prefer off-chain first, quick iterations and then we can figure out on-chain, don't want to repeat dumb mistakes ala carte RMRK team 😎

what kind of mistake? I think we can still mint metadata & attach to nft

yangwao commented 1 year ago

CORS, domain validation, server maintenance

API keys?

vikiival commented 1 year ago

Rmrk v1 and v2 wont allow this. Basilisk neither. On-chain metadata mutation works only for Statemine

roiLeo commented 1 year ago

Rmrk v2 wont allow this.

ain't it the goal of "Lego Nft"? or "multi-asset NFT"?

Or another way, would it be possible to update ipfs metadata file?

vikiival commented 1 year ago

would it be possible to update ipfs metadata file?

Except Statemine it is not possible to update collection metadata

roiLeo commented 1 year ago

You can't edit a file once it's on IPFS.

Okay that what I was looking from ipfs discuss