Collection activity: Add sorting

JustLuuuu commented 1 year ago

Is your feature request related to a problem?

I was checking this collection. Open collection - Activity. Can we please add sorting options here? So we can sort by event, addresses, amount..... To make it more interactive.

Also, add some kind of sorting here:

Describe the solution you would like

New sorting

Describe alternatives you have considered

-

Screenshots

No response

Are there opened related issues?

No response

yangwao commented 1 year ago

we've got showing by events for now on left

https://user-images.githubusercontent.com/5887929/230057513-df123a21-5ef9-4924-b6d8-785f98d00b2c.mov

and activity stream is sorted by newest occurrence on top

add some kind of sorting here:

what kind of sorting you would like to see here?

JustLuuuu commented 1 year ago

we've got showing by events for now on left

Yeah, this is good. But you cannot sort it for example by name (to see what transactions were happening on one NFT), highest amount (if you want to see the highest sales), or by addresses (the artist wants to check if someone owns more than 1 NFT and in the same time see pictures of the NFTs). My idea was just to add sorting arrows here to make it more interactive:

I know most of these things can be found somewhere else if they search it. But here it would be nice to have everything in one place :)

What kind of sorting would you like to see here?

I realized it's already sorted in a good way (not flippers because they are not working)

yangwao commented 1 year ago

highest amount (if you want to see the highest sales), or by addresses (the artist wants to check if someone owns more than 1 NFT and in the same time see pictures of the NFTs).

yup we want to keep it basic here 🤐

https://github.com/kodadot/research/issues/36

(not flippers because they are not working)

yup, seems some more crafting ⚒️ cc @daiagi 👀

daiagi commented 1 year ago

Flippers are working

See here for example https://beta.kodadot.xyz/rmrk/collection/0a24c7876a892acb79-KUBIBITS/activity?page=1

But it is missing some default display for case where there are no flippers @exezbcz

exezbcz commented 1 year ago

@JustLuuuu

to see what transactions were happening on one NFT)

for one nft is gallery detail

the artist wants to check if someone owns more than 1 NFT and in the same time see pictures of the NFTs

you can click on holder and see more options - also with pictures of the nfts
not sure if we should implement this type of sorting

My idea was just to add sorting arrows here to make it more interactive:

Yes, it would be nice. I had it planned out for the gallery item's activity, but it wasn't implemented, so maybe we can try again here

exezbcz commented 1 year ago

@daiagi Yes, when there are no flippers, I will create some copy to display.

exezbcz commented 1 year ago

Looks like it's quiet in here!

something like this? @daiagi

formatting same as in explore empty state

guess you need one for holders as well no? Or there is always the mint null address right

here is one for it anyway: Empty holder tab? Start collecting NFTs and make your mark at the top!

daiagi commented 1 year ago

I don't think we need one for holders. Nfts are always held by someone

By the way @exezbcz , I propose we change the definition of a flipper. Right now, if the minter had sold, he is considered flipper I think it should only be a person that bought and then sold

Wdyt?

exezbcz commented 1 year ago

@daiagi yeah, agree, if there is any way how to distinct minter from other flippers than go on

edit: I was also thinking about some holders tab changes since the data is just old format in rows - I will share it soon

kodadot / nft-gallery