kodadot / nft-gallery

Generative Art Marketplace
https://kodadot.xyz
MIT License
616 stars 353 forks source link

Pre-rendering pages #6284

Open yangwao opened 1 year ago

yangwao commented 1 year ago

One of things i think why we are not indexed on google is that our pre-render is not there and in the past we've been using Netlify which has somehow built in pre-render back then

Now I'm researching what we can use for prerendering, found this one

Good Q, if we can have something with CF workers?

To be continued as need wrap my head around

preschian commented 1 year ago

btw, I already proposed this poc a long time ago

cf-workers + prerender.io

here are the code https://github.com/preschian/prerender-cf-workers

cf-workers + manual construct prerendering

this is what we are using right now on canary and beta https://github.com/kodadot/workers/blob/main/ssr-opengraph/src/template.tsx

if we want simple methods and have a budget for that, I suggest using prerender.io. but, we need to fix this first https://github.com/kodadot/workers/issues/88. even though we use prerender.io methods, currently our domain in production can't hit our workers as a proxy

yangwao commented 1 year ago

btw, I already proposed this poc a long time ago

nice, I have must missed it.

have a budget for that, I suggest using prerender.io

would be that startup plan enough? https://prerender.io/pricing/ - prerenders is being triggered on visit I guess?

here are the code preschian/prerender-cf-workers

well, let's go with that one than, happy to give it a shot.

yangwao commented 1 year ago

@preschian can you briefly describe what is difference between using prerender.io and your manual construct prerendering?

cc pretender pricing https://prerender.io/pricing/

Which features we have and won't have?

preschian commented 1 year ago

what is difference between

I think the main difference is in terms of simplicity. with manual construct, we need to maintain the content for the selected routes (html/template output for bot)

with prerender.io, the content will be served automatically

yangwao commented 1 year ago

hmmm, okay, let's do release, we will test and evaluate and maybe can get back in week to this if things will still not work well, moving to p4 till then

preschian commented 1 year ago

hmmm, okay, let's do release, we will test and evaluate and maybe can get back in week to this if things will still not work well, moving to p4 till then

lmk if we want to make this more priority again. since, right now we are fixing seo stuff, I think it should be easier if we use prerender.io

roiLeo commented 1 year ago

prerender.io pricing look a bit expensive, and I think we'll definitely overpass free tier plan.

I'll ask a random question but Can this work with Nuxt3 and SSR mode?

preschian commented 1 year ago

I'll ask a random question but Can this work with Nuxt3 and SSR mode?

this is not a random question btw (good question instead XD). when we use nuxt3 and enable ssr mode we dont need prerendering stuff. so we can drop prerendering worker stuff

nuxt3 uses nitro, and it already supports cloudflare pages https://nitro.unjs.io/deploy/providers/cloudflare#cloudflare-pages

yangwao commented 1 year ago

lmk if we want to make this more priority again. since, right now we are fixing seo stuff, I think it should be easier if we use prerender.io

okay, let's go with it. I've commented on that here

prerender.io pricing look a bit expensive, and I think we'll definitely overpass free tier plan.

I would use prerender for most critical pages for SEO engines as they can do one thing well. For collections states we will stick with our existing

when we use nuxt3 and enable ssr mode we dont need prerendering stuff. so we can drop prerendering worker stuff

Is this... for real true? That's like we are at 99% of the race till the finish...

so making this p1 again as we are suffering a lot from not being indexed 😅

Ref