kodadot / nft-gallery

Generative Art Marketplace
https://kodadot.xyz
MIT License
612 stars 351 forks source link

Statemine collection not loading #6618

Closed JustLuuuu closed 8 months ago

JustLuuuu commented 10 months ago

This collection on statemine is not loading properly: production and canary too

Screenshot 2023-08-08 at 16 43 03
preschian commented 10 months ago

the creator put metadata and image on s3 bucket, not ipfs

{
  "name": "ASM Brains #5413",
  "description": "Token 5413 minted By Altered_State_Machine",
  "image": "https://polkadot-data.s3.us-east-2.amazonaws.com/metadata/nfts-88/nfts-88_item-5413-img.jpg",
  "license": "License name",
  "licenseUri": "https://license.com",
  "tags": [
    "Art",
    "Ethereum"
  ],
  "attributes": [
    {
      "label": "GENERATION",
      "value": "Genesis"
    },
    {
      "label": "COLORS",
      "value": "Blue Orange Pale Pink"
    }
  ]
}
preschian commented 10 months ago

Not sure if we should show the nft or not. metadata for this item https://kodadot.xyz/stmn/gallery/89-56217, is not a valid JSON file https://polkadot-data.s3.us-east-2.amazonaws.com/metadata/nfts-89/nfts-89_item-56217-meta.json

just for comparison, on the singular only shows if the item on ipfs https://singular.app/space/DSJV1MxfKcv1cXy25cWLYzsYZ9q1zsGqWj49o1vPAtemMeM/nfts/owned?network=statemine

preschian commented 10 months ago

steps to support non-ipfs format:

  1. need to extend image workers. WIP: https://github.com/kodadot/workers/pull/136
  2. adjust our UI to hit a new endpoint if metadata/image/mediaUri is from a custom URL
  3. adjust our UI to validate metadata as a json

seems like the creator of nft can update their nft metadata after minting on AssetHub. can someone confirm? I see there is setMetadata() from extrinsic. if that is the case, we can extend no.3 to show a popup to the user in gallery detail page and tell them that something like "metadata invalid". It would be good if the creator could update their nft metadata directly in our UI

image

roiLeo commented 8 months ago

https://kodadot.xyz/ahk/collection/88 Screenshot 2023-10-13 at 15-55-33 ASM Brains

preschian commented 8 months ago

@roiLeo why close the issue? Please see the console error. And try to visit one of the items. some features are not working, such as download and details tab

roiLeo commented 8 months ago

@roiLeo why close the issue? Please see the console error. And try to visit one of the items. some features are not working, such as download and details tab

Collection loads well on my side check screenshots

preschian commented 8 months ago

the error was not only load the image in the collection page, the asset/metadata url was on non ipfs