kodadot / nft-gallery

Generative Art Marketplace
https://koda.art
MIT License
627 stars 358 forks source link

Clearing localstorage will glitch the app (Unable to retrieve a keypair) #7187

Closed JustLuuuu closed 7 months ago

JustLuuuu commented 1 year ago

Artist (tg: @Frankford18) is trying to mint his collection: https://kodadot.xyz/ahk/collection/120 Production, AssetHub

He is getting this error: 2023-09-06 13 58 48

What it is?

roiLeo commented 1 year ago

https://docs.kodadot.xyz/tutorials/how-to-fix-error-keypair.html#_2-browser-update might help

Maybe try to clear browser cache?

JustLuuuu commented 1 year ago

https://docs.kodadot.xyz/tutorials/how-to-fix-error-keypair.html#_2-browser-update might help

Maybe try to clear browser cache?

thank you, will tell him to try

JustLuuuu commented 1 year ago

https://docs.kodadot.xyz/tutorials/how-to-fix-error-keypair.html#_2-browser-update might help

Maybe try to clear browser cache?

he did, he tried to do it all - all steps in the document you sent, he has no metadata update in polkadot.js and he ist still getting this error. His address: HC8PkF1x3LLTVpFXNuy2i8h7btKk5ZGxDX8dFZPaLPV2m87

roiLeo commented 1 year ago

he did, he tried to do it all - all steps in the document you sent, he has no metadata update in polkadot.js and he ist still getting this error. His address: HC8PkF1x3LLTVpFXNuy2i8h7btKk5ZGxDX8dFZPaLPV2m87

I can see https://kodadot.xyz/ahk/collection/120

Have you tried to mint ahk item on your side?

Could you share more infos of what he is excepting and what did he tried to do? Maybe he doesn't have enough balance?

JustLuuuu commented 1 year ago

Could you share more infos of what he is excepting and what did he tried to do? Maybe he doesn't have enough balance?

He tried:

His reply: IMG_6891

vikiival commented 1 year ago

@roiLeo would you think it would be too bad to spawn prompt and ask user which wallet does he use?

vikiival commented 1 year ago

@JustLuuuu for the context this bug happens when app is trying to find a wallet which user used to log in. If app fails to do this task, it would try to find your Wallet JSON in localStorage (aka keyring) and when it also fails it will spawn this dialog.

I am thinking to remove the keypair storage but need another fallback for the user

roiLeo commented 1 year ago

@roiLeo would you think it would be too bad to spawn prompt and ask user which wallet does he use?

wdym? looks bad for UX, maybe we can throw error in sentry. does this occur before or after the validation popup in extension?

edit: link #3591

vikiival commented 1 year ago

does this occur before or after the validation popup in extension?

As I wrote above the error is thrown when app cannot find wallet we can try rather say unable to communicate with wallet please relogin

vikiival commented 8 months ago

I would still open issue to rework the signing 😇🫶

roiLeo commented 8 months ago

I would still open issue to rework the signing 😇🫶

could you please share step to reproduce?

vikiival commented 8 months ago
  1. Login
  2. Clear localstorage
  3. Sign anything

This should fail imo

vikiival commented 8 months ago

Yup I was able to reproduce :)

Screenshot 2023-12-27 at 10 39 54