Nuxt - Transaction related problems

prury commented 9 months ago

= = still testing/editing = =

Transfer:

Tests:

DOT on Polkadot✔️
DOT on Asset Hub Polkadot ✔️
KSM on Kusama ✔️
KSM on Asset Hub Kusama ✔️
BSX on Basilisk ✔️

Problems:

[ ] ~~Transfer page Continue button never gets active~~ (Fixed)

Teleport:

Tests:

Kusama -> KusamaHub ✔️
KusamaHub -> Kusama ✔️
Kusama -> Basilisk ✔️
Basilisk -> Kusama ✔️
Polkadot -> PolkadotHub ✔️
PolkadotHub -> Polkadot ✔️

Drops:

Problems:

[ ] ~~Mint button on Drops not working and if it works it shows a mint failed message~~
[ ] ~~Ahk mint says its successful, but NFT never really gets created~~
[ ] ~~Eligibility check not working on Drops~~ (Fixed)
[x] DOT drop transaction showing error message - fixed by: #7530
[ ] DOT drop congratulations message appears before approving transaction

Identity:

Identity burning ✔️
~~identity creation(Kusama) ❌ Null on every field~~
Identity creation ✔️

Problems:

[x] ~~Not loading identities~~

NFT Interactions:

Problems:

[x] Burn on gallery item doesn't trigger transaction
[ ] ~~User is able to trigger a NFT creation transaction without selecting a collection~~(Issue Created)

Fixed:
[x] ~~On Snek you approve the transaction for NFT creation, it gets approved, but no NFT is created~~
[x] ~~List and Transfer NFT not possible as button to confirm never gets active #7479~~
[x] ~~Create new collection button never triggers transaction (Ahp, Ahk, bsx)~~
[x] ~~Create new NFT button never triggers transaction~~
[x] ~~Yolo showing on explorer instead of Buy Now~~
[x] ~~Error message when creating NFT~~
[x] ~~Make offer button on Basilisk won't work(insufficient balances)~~

Tests:

(RMRK2) Buy: ✔️
(RMRK1) Buy: ✔️
(Ahk) Buy ✔️
(Ahp) Buy ✔️
Cart buy ✔️
Cart many items buy ✔️

Tests V2:

AHK - Collection creation ✔️ Redirection ❌ NFT creation - ✔️ redirection - ✔️ copies ✔️ Properties - not showing

BSX Collection creation - ✔️ redirection - ❌ NFT creation - ✔️ redirection - ✔️ copies - ✔️ Properties - not showing

AHP Collection creation ✔️ redirection - ❌ ~~NFT creation - Failing, even if i have 18 dot on Assethub~~ (Works) redirection - copies - properties -

RMRK 2 and 1 Collection creation - ✔️ redirection - ❌ NFT creation - ✔️ second transaction for listing - ✔️ redirection - ✔️ copies - ✔️ Properties - only showing carbonless

change price and transfer working across all of them ✔️

Massmint

[ ] After uploading file, UI will not let you go to the second step

prury commented 9 months ago

cc: @yangwao

yangwao commented 9 months ago

Seems buys works on AHK for me

https://nuxt.kodadot.xyz/ahk/gallery/132-29?listed=true

prury commented 9 months ago

Seems buys works on AHK for me

* https://nuxt.kodadot.xyz/ahk/gallery/132-29?listed=true
  ![image](https://user-images.githubusercontent.com/5887929/272232208-68e85718-020a-4ac5-8c68-689559141914.png)

tyty, will add it to the list and test buy on other chains as well

roiLeo commented 9 months ago

identity creation(Kusama) ❌ Null on every field

It worked for me (check tx) is there a particular way to reproduce it?

prury commented 9 months ago

identity creation(Kusama) ❌ Null on every field

It worked for me (check tx) is there a particular way to reproduce it?

tried again and it worked, why? haha

Jarsen136 commented 9 months ago

Drops:

Problems:

[ ] Mint button on Drops not working and if it works it shows a mint failed message

This one should have been fixed on https://nuxt.kodadot.xyz due to some fix on the graphql request.

yangwao commented 9 months ago

Create new collection button never triggers transaction (Ahp, Ahk, bsx)

[ ] Create new NFT button never triggers transaction

https://github.com/kodadot/nft-gallery/pull/7502 cc @prury

Is there anything critical left to be done as to why we should hold on promoting nuxt for production?

prury commented 9 months ago

Create new collection button never triggers transaction (Ahp, Ahk, bsx)

[ ] Create new NFT button never triggers transaction
* [fix: create nft #7502](https://github.com/kodadot/nft-gallery/pull/7502) cc @prury
Is there anything critical left to be done as to why we should hold on promoting nuxt for production?

Will keep looking for problems, as i have been doing. Probably nothing critical but i would proceed with caution, i still have to check different media(3d, audio, mp4) nfts and finish checking nft interaction after the recent fixes.

Search needs fixing

i would wait a bit before pushing nuxt into production, even non critical bugs can ruin user experience imho

prury commented 9 months ago

Create new collection button never triggers transaction (Ahp, Ahk, bsx)

[ ] Create new NFT button never triggers transaction
* [fix: create nft #7502](https://github.com/kodadot/nft-gallery/pull/7502) cc @prury

checking rn

prury commented 9 months ago

@yangwao updated

yangwao commented 8 months ago

look like good to go? we will discus this week if we should push it for main and then make it public following week. probably some public bug hunty campaign to see if we missed some bugs

prury commented 8 months ago

look like good to go? we will discus this week if we should push it for main and then make it public following week. probably some public bug hunty campaign to see if we missed some bugs

only important thing missing its Polkadot AssetHub nft creation

yangwao commented 8 months ago

@prury let's create separate issues from outstanding issues and we can close this one

thank you for making this one!

kodadot / nft-gallery