exezbcz commented 8 months ago

part of a bigger issue:

7552

Home page

Top part

introduces into migration, shows important parts - like the route etc.

source and destination

same as in teleport v2 (#7363)
gives the option to choose whether migrating from Polkadot assethub or Kusama asset hub. The default is polkadot.
The source is Kusama, or if its more clearer maybe rmrk2, It is up to the devs

Faq

I have decided to put faq on the top there
migration is pretty hard to understand for new users. This will hopefully ensure the users are not confused about what is happening.
states are on the left:
please note that the height will be taken from the card with the most text - other cards will inherit the height (that means cards are consistent and won't jump around)
if you would like to add anything as an explainer to the cards, feel free to comment.

Selection

under the full-width divider, there is a contextual message with the account you are connected with, and then there is a little tooltip section.
there is also a state for when you are not connected.
tooltip copy for that as well.
the selection is filled with drop landing page-like cards.
cards have a hover effect, and the migrate button itself has one as well.
you can try it yourself in the prototype next to the card component.

Ready for Migration

Here, you will be able to view collections that you own.
As the creator or owner of a collection, you can initiate migration here. Keep in mind only items owned by you can be migrated at this stage. You'll need to pre-sign items owned by others to allow individual migrations.
if there is no collection to be migrated from this part, this part is simply hidden.

Waiting for your action

here are items from collections you don't own, but the collection was migrated and initiated - giving you the option to migrate as well.
Displayed here are individual items that you own from collections that have been migrated. Ensure you're up-to-date by migrating these pieces right away. Please note you can only start the migration once the collection owner initiates it.

migration not possible

pretty sure there will be some collections that you won't be able to migrate. For this we have the last part under divider.

yangwao commented 8 months ago

Hey @kodadot/internal-dev if someone would pick this one to start?

preschian commented 8 months ago

I will check this one

preschian commented 8 months ago

Actually, I'm still not familiar with the migration script. I will try to finish the UI first with dummy data and integrate it with real data later

kodabot commented 8 months ago

ASSIGNED - @preschian 🔒 LOCKED -> Saturday, October 14th 2023, 22:48:15 UTC -> 36 hours

vikiival commented 8 months ago

Actually, I'm still not familiar with the migration script. I will try to finish the UI first with dummy data and integrate it with real data later

I think let's start with UI.

kodabot commented 8 months ago

ASSIGNMENT EXPIRED - @preschian has been unassigned.

preschian commented 8 months ago

@vikiival how to check if the collection is ready to migrate, waiting, or not supported?

vikiival commented 8 months ago

Any collection issuer and current owner of is possible to be migrated On both KSM and RMRK

preschian commented 8 months ago

@vikiival

How do we check if the collection has already been migrated?
Does it mean migration was impossible if the collection owner had yet to migrate? Is that correct?

vikiival commented 8 months ago

How do we check if the collection has already been migrated?

Good Q. Will add it to the API. The full desc is here https://github.com/kodadot/nft-gallery/issues/7562#issuecomment-1772705044

Therefore you can ask api if collection was migrated or not

Does it mean migration was impossible if the collection owner had yet to migrate? Is that correct?

Sorry, I do not understand your question. Can you please rephrase your request?

preschian commented 8 months ago

Good Q. Will add it to the API. The full desc is here #7562 (comment)

👍👍

Does it mean migration was impossible if the collection owner had yet to migrate? Is that correct?

Sorry, I do not understand your question. Can you please rephrase your request?

oops, sorry, I mean, if the collection owner has not yet migrated. for this section:

vikiival commented 8 months ago

oops, sorry, I mean, if the collection owner has not yet migrated. for this section:

Like You can migrate anything

API has call for all you your collection that you have migrated

GET /relocations/issuers/${accountId}

returns a list

Currently I am unable to deploy waifu worker

Screenshot 2023-10-25 at 17 13 26

preschian commented 8 months ago

API has call for all you your collection that you have migrated
GET /relocations/issuers/${accountId}
returns a list

Currently I am unable to deploy waifu worker

lmk if the endpoint deployed 👍 I will open followup PR

Like You can migrate anything

@vikiival @exezbcz, should we update the "Migration Not Possible" design?

vikiival commented 8 months ago

mk if the endpoint deployed 👍 I will open followup PR

published the waifu worker

There are no data yet full desc was updated in https://github.com/kodadot/nft-gallery/issues/7562#issuecomment-1772705044

exezbcz commented 8 months ago

should we update the "Migration Not Possible" design?

yeah we can remove it :D

vikiival commented 7 months ago

cc @preschian any blocker here?

preschian commented 7 months ago

any blocker here?

hi hi, I need help with this one #8206

regarding this https://github.com/kodadot/nft-gallery/pull/8201#issuecomment-1824594927, iiuc @exezbcz will have some updated version

exezbcz commented 7 months ago

should we update the "Migration Not Possible" design?

yeah we can remove it :D

I guess this, the waiting for your action design is still valid

preschian commented 7 months ago

should we update the "Migration Not Possible" design?

yeah we can remove it :D

I guess this, the waiting for your action design is still valid

@exezbcz hhmm, I don't understand. Could you elaborate more? In PR #8201, that section was removed. need to adjust this one, right? (waiting for your action section) https://github.com/kodadot/nft-gallery/pull/8201#issuecomment-1824594927

especially I need help with these parts:

now the waiting for your action is not correct -> what/how is the correct one?
for the bottom part, I will probably change the text a bit -> what is the text?

exezbcz commented 7 months ago

for the bottom part, I will probably change the text a bit -> what is the text?

this will be removed, the part is not needed

what/how is the correct one?

correct one is that it shows what is described in the issue

here are items from collections you don't own, but the collection was migrated and initiated - giving you the option to migrate as well.

Displayed here are individual items that you own from collections that have been migrated. Ensure you're up-to-date by migrating these pieces right away. Please note you can only start the migration once the collection owner initiates it.

does that make sense? cc @preschian

preschian commented 7 months ago

@exezbcz I probably misunderstood your requirements. Here are some updates in #8280

"Budget Spaceships" -> I have one item from this collection. But, the owner still has not migrated the collection yet -> there are no buttons on the card. "AI Cyberpunks" -> I have one item, and the owner already migrated that to ahk -> there is a button to migrate my items.

Is that correct?

preschian commented 7 months ago

@exezbcz I mocked the address locally with your address. It should show up like this

preschian commented 7 months ago

hmmm, wait, maybe the titles between "Ready for Migration" and "Waiting For Your Action" are confusing. We need to change the words, I guess? Because the user can't do anything unless the collection owner migrates the collection

exezbcz commented 7 months ago

Budget Spaceships" -> I have one item from this collection. But, the owner still has not migrated the collection yet -> there are no buttons on the card.

the card should not be visible, its showed only after its possible to follow the migration, that is why its "waiting for your action"

It should show up like this

yeah but without the waiting for your action section - owner of the collections did not migrate the collection yet

preschian commented 7 months ago

the card should not be visible

aahh, I see, hide the card completely instead. will update that

exezbcz commented 7 months ago

@preschian correct, plus when there is no card, the section is hidden

that only applies to waiting for you action, ready for migration will probably have a empty state design

kodadot / nft-gallery

Migration UI - 1 - Home page #7560

7552

Home page

Top part

source and destination

Faq

Selection

Ready for Migration

Waiting for your action

migration not possible