kodadot / nft-gallery

Generative Art Marketplace
https://koda.art
MIT License
638 stars 360 forks source link

Generate preview image for Video files while minting nft #7971

Open JustLuuuu opened 11 months ago

JustLuuuu commented 11 months ago

Video files: The newest list on landing looks like this:

Screenshot 2023-11-08 at 15 51 07

Collection: https://kodadot.xyz/ahk/collection/249 To be able to see them, you need to click on play - can it be played automatically? Or can we have some prettier previews?

Video: https://github.com/kodadot/nft-gallery/assets/104380776/f8d34aae-28f3-4dc0-ac48-f9923a9d369c

Also when you open his profile and activity, they look like this:

Screenshot 2023-11-08 at 16 02 09
daiagi commented 11 months ago

iirc it is not by mistake loading videos automatically was making explore pages very slow to load iirc @Jarsen136 was the one who solved that issue, partly by stopping autoload

Jarsen136 commented 11 months ago

loading videos automatically was making explore pages very slow to load iirc @Jarsen136 was the one who solved that issue, partly by stopping autoload

TBH I don't remember that : ) I only remember that I solved the related issue with iframe nft instead of video one.

I will take a look at this issue and enable video autoplay on the landing page.

Jarsen136 commented 11 months ago

👋

kodabot commented 11 months ago

ASSIGNED - @Jarsen136 🔒 LOCKED -> Friday, November 10th 2023, 22:03:15 UTC -> 36 hours

JustLuuuu commented 11 months ago

video doesnt need to be played, at least if we can see a preview :)

Jarsen136 commented 11 months ago

video doesnt need to be played, at least if we can see a preview :)

There is no preview image for the video type nft, so we have to play it to display something.

Jarsen136 commented 11 months ago

video doesnt need to be played, at least if we can see a preview :)

There is no preview image for the video type nft, so we have to play it to display something.

Then I guess we need a preview image for the video nft without playing it. I would change the description for the issue.

kodabot commented 11 months ago

ASSIGNMENT OVER - @Jarsen136 has been unassigned.

kodabot commented 11 months ago

ASSIGNMENT EXPIRED - @Jarsen136 has been unassigned.