search

kodadot / nft-gallery

Generative Art Marketplace
https://kodadot.xyz
MIT License
616 stars 353 forks source link

Dot for decimals and placeholder #8927

Open exezbcz opened 6 months ago

exezbcz commented 6 months ago

image

there is currently "," instead of "."

we use "," for thousands

and there is also wrong placeholder, when I first loaded the modal, there was offer.(something)

hassnian commented 6 months ago

👋

kodabot commented 6 months ago

ASSIGNED ISSUES LIMIT REACHED - @hassnian, you have been already assigned with 5 issues: 6955,8163,8889,8890,8928,8926,8837. Finish one of them in order to get more issues assigned!

roiLeo commented 6 months ago

there is currently "," instead of "."

we use "," for thousands

Depends the country you live in, IMO this is valid

exezbcz commented 6 months ago

@roiLeo yup, agree, but it should be consistent with other formats in the app

image image
hassnian commented 6 months ago

@roiLeo from what I could check, you can't force . using type="number " , best i could find was adding the attribute lang , but that only works for firefox , chrome fallbacks on user settings

ic you did #8893

got any suggestions ?

roiLeo commented 6 months ago

got any suggestions ?

check work on #8940