kodadot / nft-gallery

Generative Art Marketplace
https://koda.art
MIT License
627 stars 359 forks source link

Aesthetic Alchemy: Identical mints #9142

Closed JustLuuuu closed 6 months ago

JustLuuuu commented 7 months ago

These two mints are identical:

Screenshot 2024-01-26 at 12 06 50

This one and this one.

How did it happen? This should not happen next time. Minted by the same address.

prury commented 6 months ago

https://canary.kodadot.xyz/ahk/gallery/379-18 https://canary.kodadot.xyz/ahk/gallery/379-19 image

exezbcz commented 6 months ago

is there anything we can do @vikiival ?

vikiival commented 6 months ago

The art is not same:

First does not respect that api needs to be called after success mint (cc @preschian)

image

Second is oki

image

Why you see the same pictures is that app does not respect the fact that should only use image data from the iframe and not the capture service cc @Jarsen136

JustLuuuu commented 6 months ago

Does it have solution?

Jarsen136 commented 6 months ago

Why you see the same pictures is that app does not respect the fact that should only use image data from the iframe and not the capture service cc @Jarsen136

I do not understand tbh. I guess it's because the user opens two tabs at the same time and then he mints twice with the same variation. (Both #17 and #18 nft were minted by the same user)

A possible solution would be to force random variation after every refresh. In other words, the solution is to remove the default value and always return a new one. wdyt ? @vikiival

vikiival commented 6 months ago

I do not understand tbh.

You should never call

https://github.com/kodadot/nft-gallery/blob/9fbb9e57ffb09b021e33399c4bb23d1884e6e0c8/composables/drop/useGenerativeDropMint.ts#L115

And the only way how to obtain image is this:

https://github.com/kodadot/nft-gallery/blob/9fbb9e57ffb09b021e33399c4bb23d1884e6e0c8/composables/drop/useGenerativeDropMint.ts#L57

In other words, the solution is to remove the default value and always return a new one.

There should be no default value imo

Jarsen136 commented 6 months ago

I do not understand tbh.

You should never call

https://github.com/kodadot/nft-gallery/blob/9fbb9e57ffb09b021e33399c4bb23d1884e6e0c8/composables/drop/useGenerativeDropMint.ts#L115

And the only way how to obtain image is this:

https://github.com/kodadot/nft-gallery/blob/9fbb9e57ffb09b021e33399c4bb23d1884e6e0c8/composables/drop/useGenerativeDropMint.ts#L57

In other words, the solution is to remove the default value and always return a new one.

There should be no default value imo

Will raise a PR for it

preschian commented 6 months ago

@vikiival @Jarsen136 should we check on the worker side also? ensure that the hash/image is unique

duplicate hash on meadow

image