Implement new features to Drop

kodadot / nft-gallery

Generative Art Marketplace

https://koda.art

MIT License

627 stars 359 forks source link

Implement new features to Drop #9296

Closed JustLuuuu closed 6 months ago

JustLuuuu commented 7 months ago

SailWings: https://kodadot.xyz/ahp/drops/sailwings

The artist behind this collection told me that there is in the code implemented to his art:

save art by "s" and
save frame by "v"

I tried it and it's not working on KodaDot for this collection. - Maybe it will work once the art is minted? I tried it only on the drop page.

Anyway, this is not the first time art has had this extra features. Some artists are implementing these things to code all the time, it saves various formats, changes the art, etc.

1) Would be good to support this 2) Would be good to have it somewhere visible - not in description. As description on Koda is partially hidden. Fxhash has it in description. - which is meh. @exezbcz wdyt should it be part of desc?

preschian commented 7 months ago

You can hit the shortcut if you visit the art directly. Try this one https://kodadot-ultra.myfilebase.com/ipfs/bafybeifyqauwmxvymiqktvaxs47tcl5kikdzd45adagsrnrxlajaq6xefm/?hash=0x2517558b3a390a58028987d1fe131557af7793c9ff7cc384aec21ba3a27f36a6

that one is from sailwings

JustLuuuu commented 7 months ago

Okay so we support this, thats amazing, so i guess now the only question is if we wanna be adding that to descriptions or just somewhere else, maybe in details of the NFT?

JustLuuuu commented 7 months ago

@preschian

https://kodadot.xyz/ahp/gallery/91-64 I tried clicking s and v and it didn't do anything. I did in on item page and also after opening the art. I guess I should open a separate issue for it?

preschian commented 7 months ago

@JustLuuuu, if you click the link on "Animated Media", it will open the art in the new tab. Then, you can press the shortcut.

Currently, it still doesn't work to press the shortcut on the gallery detail page. does it work on fxhash gallery detail page?

JustLuuuu commented 7 months ago

Currently, it still doesn't work to press the shortcut on the gallery detail page. does it work on fxhash gallery detail page?

It does not. You are right. But they have this button "open" where they can do that. Which is more convenient than searching in details and clicking on animated media. Maybe we should have that too?

preschian commented 7 months ago

But they have this button "open" where they can do that.

Yes, I think it would be nice if we had that too

JustLuuuu commented 6 months ago

Moving to https://github.com/kodadot/nft-gallery/issues/9355