kodadot / nft-gallery

Generative Art Marketplace
https://koda.art
MIT License
627 stars 359 forks source link

Video thumbnail not showing on profile activity #9458

Closed prury closed 6 months ago

prury commented 6 months ago

https://canary.kodadot.xyz/ahk/u/FSRpCqLadBfyxQ5MCY7PiwKsmhXPBLzvGDL4s8F4S9zMNCs?tab=activity&buy=true&sale=true&mint=true&transfer=true&list=true

image

hassnian commented 6 months ago

👋

kodabot commented 6 months ago

ASSIGNED ISSUES LIMIT REACHED - @hassnian, you have been already assigned with 5 issues: 6955,8163,8890,9173,9456,9488,9499. Finish one of them in order to get more issues assigned!

hassnian commented 6 months ago

@preschian seems to me the same issue as this one or very similar https://github.com/kodadot/nft-gallery/pull/8729 ?

one of those nfts

metadata

placeholder as image

I remember this comment https://github.com/kodadot/nft-gallery/pull/8729#discussion_r1439219391

but then we concluded with this https://github.com/kodadot/nft-gallery/pull/8729#pullrequestreview-1800061910

what do you think

preschian commented 6 months ago

@preschian seems to me the same issue as this one or very similar #8729 ?

Correct, same issue. I think we can change that component with MediaItem for now. At least it shows the correct thumbnail.

one of those nfts

metadata

placeholder as image

yes, this is the problem. The question is, Why is the placeholder image being set in the metadata

Maybe need to stress test our minting page by minting video recursively. to find the root cause cc @prury

prury commented 6 months ago

@preschian seems to me the same issue as this one or very similar #8729 ?

Correct, same issue. I think we can change that component with MediaItem for now. At least it shows the correct thumbnail.

one of those nfts metadata placeholder as image

yes, this is the problem. The question is, Why is the placeholder image being set in the metadata

Maybe need to stress test our minting page by minting video recursively. to find the root cause cc @prury

will do

hassnian commented 6 months ago

@preschian #9517 👀

daiagi commented 6 months ago

The question is, Why is the placeholder image being set in the metadata

agree. that is indeed the question and the root cause of https://github.com/kodadot/stick/issues/223 as well

image