search

kodadot / nft-gallery

Generative Art Marketplace
https://kodadot.xyz
MIT License
616 stars 353 forks source link

Minted drop nft different from generated preview #9525

Closed prury closed 4 months ago

prury commented 4 months ago

i think i was able to reproduce step 1: go to drop page, generate a preview step 2: refresh page, generate other previews it will mint the preview generated by first step

https://github.com/kodadot/nft-gallery/assets/36627808/ffbfcb19-2809-4b7a-bc80-fe146c67bc19

kodabot commented 4 months ago

ASSIGNED - @Jarsen136 🔒 LOCKED -> Saturday, February 24th 2024, 03:53:26 UTC -> 36 hours

Jarsen136 commented 4 months ago

It's a worker side issue and there is nothing can do on frontend to fix it.

Let me expand more about what causes it. Once we call api /drops/allocate/xxx to get the allocated result, the image and hash would be saved forever.

image. Next time no matter what kind of new image we generate, the new image will not be used. Instead, the saved image would be used.

possible solution

If we want users to be able to mint the latest generative image, regardless of whether to refresh the page. We need to rework /drops/allocate/xxx api, so that the images and hash could be updated.

@vikiival @preschian

kodabot commented 4 months ago

ASSIGNMENT OVER - @Jarsen136 has been unassigned.

preschian commented 4 months ago

checking

so, to reproduce is

  1. click "Mint" button
  2. then, close the modal is that correct?
Jarsen136 commented 4 months ago

checking

so, to reproduce is

  1. click "Mint" button

  2. then, close the modal

is that correct?

Yes

vikiival commented 4 months ago

  1. there is nothing can do on frontend to fix it

There could be solution So if you have unclaimed allocation show it to the user? ;) there is always a way for that.

  1. Second possible fix is to update allocation with a new hash.

  2. is to supply hash with finish drop, but it will have a lot of unpleasant side effects

Jarsen136 commented 4 months ago

  1. there is nothing can do on frontend to fix it

There could be solution So if you have unclaimed allocation show it to the user? ;) there is always a way for that.

Yes It would work and needs some extra UX changes.

  1. Second possible fix is to update allocation with a new hash.

It's ideal because it gives users the chances to cancel and change image : )