kodadot / nft-gallery

Generative Art Marketplace
https://koda.art
MIT License
627 stars 359 forks source link

this message is preventing me from minting(no nfts were ever minted on collection), and when i try it stops me from minting #9563

Closed daiagi closed 6 months ago

daiagi commented 6 months ago

@vikiival is it correct to use doWafiu here? https://github.com/kodadot/nft-gallery/blob/12372c1c3aebf3c5015f2c89c0788a798365f52f/components/collection/drop/Generative.vue#L242

or should we use fxart worker? if fxart worker

is it a. /drops/allocate/${id} b. /drops/do/${id} endpoint?

or validate these answers:

  1. it should be fxart worker, and it should use /drops/allocate/${id} endpoint
preschian commented 6 months ago

eh, I think this component is not updated yet. Should call fxart

https://github.com/kodadot/nft-gallery/blob/12372c1c3aebf3c5015f2c89c0788a798365f52f/components/collection/drop/Generative.vue#L242

So far, we have only changed PaidGenerative.vue and HolderOfGenerative.vue

https://github.com/kodadot/nft-gallery/blob/12372c1c3aebf3c5015f2c89c0788a798365f52f/components/collection/drop/PaidGenerative.vue#L359-L368

daiagi commented 6 months ago

@preschian yep, so i though

ill do this one quick and dirty and create follow up to refactor as part of #9562

there is too much repetition in minting logic between variations minting logic should be in 1 place

preschian commented 6 months ago

there is too much repetition in minting logic between variations minting logic should be in 1 place

agree 👍🏻

daiagi commented 6 months ago

@preschian

So far, we have only changed PaidGenerative.vue and HolderOfGenerative.vue

so it's allocateClaim? not allocateCollection fxart readme does not seem to agree

preschian commented 6 months ago

since /do/:id need to find from table_ref https://github.com/kodadot/private-workers/blob/0cea59de48fad3d11cdf6b2a0920da30d72a7372/fxart/src/routes/drops.ts#L438-L441

It needs both of them. Is it possible?

daiagi commented 6 months ago

@preschian i DM'd you in telegram

kodabot commented 6 months ago

ASSIGNED - @daiagi 🔒 LOCKED -> Wednesday, February 28th 2024, 17:15:07 UTC -> 36 hours