feat: Mass Minting in drop page

[hassnian]

PR Type

• [ ] Bugfix
• [x] Feature
• [x] Refactoring

Context

• [x] Closes #9136
• [x] Closes https://github.com/kodadot/private-workers/issues/84

Needs QA check

• @kodadot/qa-guild please review

• amount of nfts that you can mint depends on:

  • paid: only (balance / price)
  • holderOf: min between (balance / price) and amount of available nfts

• when minting one nft , ensure it's not generating a new one , ie it's using the same

• when multiple nfts are being generated , no duplicates should be generated
• paid , paid + holderOf , holdeof , mass mint code has been added , free code refactoring but still should be tested

Needs Design check

• @exezbcz please review

Did your issue had any of the "$" label on it?

• [x] Fill up your DOT address: Payout

Screenshot 📸

• [ ] My fix has changed something on UI;

[daiagi]

https://dev.to/alexanderop/mastering-vue-3-composables-a-comprehensive-style-guide-46p9

[yangwao]

I've fixed that deploys should work against other branches, so prury can test tho

[netlify[bot]]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	681e53aed4c8c4d1cdc111897fd95b18171cef11
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/65f2e13afa46af00083e8290
😎 Deploy Preview	https://deploy-preview-9711--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[yangwao]

Netlify can't build tho

1:18:40 PM: [error] Nuxt Build Error: [vite:load-fallback] Could not load /opt/build/repo/composables/drop/massmint/useDropMassmintState (imported by components/collection/drop/modal/PaidMint.vue?vue&type=script&setup=true&lang.ts): ENOENT: no such file or directory, open "/opt/build/repo/composables/drop/massmint/useDropMassmintState" 1:18:40 PM:  ELIFECYCLE  Command failed with exit code 1. (https://ntl.fyi/exit-code-1)

[hassnian]

Netlify can't build tho

1:18:40 PM: [error] Nuxt Build Error: [vite:load-fallback] Could not load /opt/build/repo/composables/drop/massmint/useDropMassmintState (imported by components/collection/drop/modal/PaidMint.vue?vue&type=script&setup=true&lang.ts): ENOENT: no such file or directory, open "/opt/build/repo/composables/drop/massmint/useDropMassmintState" 1:18:40 PM:  ELIFECYCLE  Command failed with exit code 1. (https://ntl.fyi/exit-code-1)

deployed https://deploy-preview-9711--koda-canary.netlify.app/

[yangwao]

deployed deploy-preview-9711--koda-canary.netlify.app

yup testing

seems list maybe it's not done yet as I see it's draft PR

mints took >1 minute to render when I visited, but probably not scope of this pr

• https://deploy-preview-9711--koda-canary.netlify.app/ahp/gallery/108-69
• https://deploy-preview-9711--koda-canary.netlify.app/ahp/gallery/108-70

[exezbcz]

minted 3

the same happened (in the mass list there were no items)

after coming back to the drop page

[yangwao]

Minor Allowlist bug I have eligible on left, button on right not eligible

[yangwao]

okay, trying to battle test it before it goes out, sweet work @hassnian !

[yangwao]

Probably add sharing on Farcaster but probably coming once merged I guess as it's on main already

[yangwao]

Got hung up on slow rendering arts (as I expected), minor for now https://deploy-preview-9711--koda-canary.netlify.app/ahp/drops/sailwings

Can be done follow up

• 9719

Details

 

[prury]

that preheating error that we were talking about is happening when you cancel the massminting and try again hassnian, i see now

also if i cancel the massmint dialog and try to massmint again the button will not work, but probably a problem coming from refactor, will check

[yangwao]

but probably a problem coming from refactor, will check

thought that refactor should actually solve this?

[prury]

waiting for:

[yangwao]

fix(PaidGenerative.vue): empty listing cart

numbering is missing but I guess it's because of something else?

[yangwao]

waiting for:

mints took >1 minute to render when I visited

yup, but probably outside scope of this one

[prury]

fix(PaidGenerative.vue): empty listing cart

numbering is missing but I guess it's because of something else? ![image](https://private-user-images.githubusercontent.com/

yup, its something else

[prury]

but probably a problem coming from refactor, will check

thought that refactor should actually solve this?

i'm still checking for bugs on the open PR from daiagi, button state got refactored recently there

[hassnian]

@kodadot/internal-dev

https://fxart-beta.kodadot.workers.dev/drops/meadow

returning minted 0

{
    "id": "genmeadow",
    "chain": "ahk",
    "collection": "379",
    "disabled": 0,
    "image": "ipfs://bafkreic7ii2fvo3fhe557pyozhzitkfnhgmxovaebnf3shqmjiva42erb4",
    "name": "MEADOW",
    "banner": "ipfs://bafkreic7ii2fvo3fhe557pyozhzitkfnhgmxovaebnf3shqmjiva42erb4",
    "alias": "meadow",
    "content": "ipfs://bafybeicdv7iu5racra3vsvg2k2uvp2jxvb534h67f6lqdwidhmvzg2tjou",
    "type": "paid",
    "max": null,
    "minted": 0,
    "meta": "20000000000",
    "price": "5000000000",
    "holder_of": null,
    "location": null,
    "start_at": null
}

[yangwao]

Hey @kodadot/internal-dev, is there any critical review from you? Otherwise, I want to have it in tomorrow's release as it was tested with a few people. It looks solid to me.

We can always do post-refactor, yet we want it out, which I believe helps us on the revenue side.

Then drops-refactor can be merged to main

[preschian]

fxart-beta.kodadot.workers.dev/drops/meadow

returning minted 0

related https://github.com/kodadot/private-workers/issues/80

you can use this instead at the moment (afaik until now we still use this) fxart-beta.kodadot.workers.dev/drops/meadow/status

Hey @kodadot/internal-dev, is there any critical review from you?

For now, I'm still unwell today, unable to review, I believe in @prury 🙏🏻 Same for this PR https://github.com/kodadot/nft-gallery/pull/9709

I will check tomorrow after it merged 🙏🏻🙏🏻🙏🏻

[yangwao]

I'm still unwell today

oh, get well!

[yangwao]

@hassnian let's fix merge conflicts, hopefully nothing much critical, I'm happy to test it afterwards

[yangwao]

Once this PR is merged, let's make PR to merge drops-refactor to main

• https://github.com/kodadot/nft-gallery/pull/9711

[prury]

noticed that time estimation on listing its not correct, but can be fixed later it resets after some time, like it was estimating the time for each of nfts to be listed

[prury]

mobile needs some small work:

[prury]

not being able to type in the amount is on purpose?

[prury]

i would not merge this PR until the following is solved: 🚫

https://github.com/kodadot/nft-gallery/assets/36627808/5066698b-7562-459d-888d-6273204ac629 only the ones on the right got minted:  what happens when two users click barely at the same time: https://github.com/kodadot/nft-gallery/assets/36627808/5c404e22-1ef1-47cd-8633-b861f56219b5

[exezbcz]

mobile needs some small work:

we can stack the two if it does not fit

[daiagi]

@hassnian forgot to push maybe?

i don't see your latest changes

[hassnian]

@hassnian forgot to push maybe?

i don't see your latest changes

was planning re-request a review once I was done with all the comments

[daiagi]

was planning re-request a review once I was done with all the comments

you're right. apologies

[yangwao]

Gonna test, if it would be okayish, we are merging and then to the main branch, so @prury have like last 2-3 hours for final checks if something is missing

[yangwao]

works! found something minor, but I guess 409 should not be issue in this case? I've clicked once and then clicked elsewhere so probably that's why.

|

[yangwao]

@hassnian let us know when you are good to go, I see you are adjusting something

[hassnian]

@hassnian let us know when you are good to go, I see you are adjusting something

will do

[yangwao]

Mobile does job well too

[hassnian]

all @daiagi comments have been solved, should be ok now , checking @prury comments

[yangwao]

How come conflicts surfaced? There was none last 30 minutes. Coming from?

• https://github.com/kodadot/nft-gallery/pull/9753

[daiagi]

How come conflicts surfaced? There was none last 30 minutes. Coming from?

yes, because i pulled main into drops-refactor

[daiagi]

@yangwao revert?

merge this into drop-reafctor and then reconcile with main?

it's gonna be a bomb shell

[yangwao]

it's gonna be a bomb shell

I don't think so as if you pulled main -> drops-refactor, this PR shows conflicts between drops-refactor <-> drops-refactor-mass-mint, hope I'm not wrong.

Even I'm aware of

[yangwao]

@hassnian still up? very last one batch of merge conflicts. Then I will fly over to test it to make sure it's working.

[hassnian]

@hassnian still up? very last one batch of merge conflicts. Then I will fly over to test it to make sure it's working.

checking

[daiagi]

@hassnian look like some code never got pushed

i got some comments you say fixed but doesn't appear fixed to me

[yangwao]

i got some comments you say fixed but doesn't appear fixed to me

if it's not critical can we resolve in follow up, when this would be merged against main 🙏 so far mass mint has worked in primary case for me and others. There was some edge cases I've seen

[daiagi]

if it's not critical can we resolve in follow up, when this would be merged against main 🙏

your wish is my command

[yangwao]

your wish is my command

[daiagi]

@yangwao i didn't get the dune reference / joke

guess i need to watch Dune2

[sonarcloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud