feat: Add stats for collections - Githubissues

kodadot / rubick

Implementation SubSquid indexer for Kusama NFTs

https://github.com/kodadot/rubick

9 stars 15 forks source link

feat: Add stats for collections #236

Closed Matehoo closed 1 year ago

Matehoo commented 1 year ago

TODO:

[x] proper testing

PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[x] PR closes #10
[ ] This PR is required for kodadot/nft-gallery#

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've run the indexer and it hasn't failed
[x] I've changed schema and performed a migration
[ ] I found edge cases

Screenshot

[ ] My contribution is a resolver so I have pic from playground

vikiival commented 1 year ago

WDYT @Matehoo ?

I think it looks much cleaner

Matehoo commented 1 year ago

I also think this way is better, its certainly more performant than before

Matehoo commented 1 year ago

@vikiival can we also merge this?

vikiival commented 1 year ago

I've run the indexer and it hasn't failed?

Matehoo commented 1 year ago

I've run the indexer and it hasn't failed?

For test I ran the indexer for 30 mins and didnt get any errors related to the added functionality