search

kodadot / rubick

Implementation SubSquid indexer for Kusama NFTs
https://github.com/kodadot/rubick
9 stars 15 forks source link

empty `resources` on this nft #265

Open preschian opened 10 months ago

preschian commented 10 months ago 
          > can you check? [deploy-preview-6599--koda-canary.netlify.app/ksm/gallery/15635794-54bbd380dc3baaa27b-EVRLOOT-ADVANCED_FISHINGROD-2](https://deploy-preview-6599--koda-canary.netlify.app/ksm/gallery/15635794-54bbd380dc3baaa27b-EVRLOOT-ADVANCED_FISHINGROD-2)

I can only fix the "More from this collection" section

for this specific nft seems like from the indexer side. on rmrk2 at least need some resources. this nft meta.image and resources was empty image

Originally posted by @preschian in https://github.com/kodadot/nft-gallery/issues/6599#issuecomment-1672720590

vikiival commented 10 months ago

Hello, can you please rephrase your question? Or provide more context?

preschian commented 10 months ago

Hello, can you please rephrase your question? Or provide more context?

hi @vikiival, how to get the image for this item https://canary.kodadot.xyz/ksm/gallery/15635794-54bbd380dc3baaa27b-EVRLOOT-ADVANCED_FISHINGROD-2 there is no meta.image or resources from the indexer

return null and empty []

preschian commented 10 months ago

Another item in the same collection we can get the resources

image

vikiival commented 10 months ago 
{
  "data": {
    "token": {
      "id": "15635794-54bbd380dc3baaa27b-EVRLOOT-ADVANCED_FISHINGROD-2",
      "metadata_name": "Reinforced Palm Rod",
      "rootowner": "EVRLT14nteG7mp31N4cmTTpYdDnjxEr25zQwXKC3Suph6L2",
      "resources": [],
      "equipped": null
    }
  }
}

Hello, this is not an issue of our indexer, I checked against RMRK Prod API and NFT does not contain any resources

preschian commented 10 months ago

I see, so it was expected then

do we need to adjust our UI? maybe tell the user "Media not found for this item"

preschian commented 10 months ago

anyway, when I search "Reinforced Palm Rod" on singular they show only "439 results" https://singular.app/collectibles/kusama/54bbd380dc3baaa27b-EVRLOOT?isVerified=false&showPending=true&network=kusama&searchQuery=Reinforced%20Palm%20Rod&sortBy=minted_at:desc&page=6

on our UI, shows "444 items" https://canary.kodadot.xyz/ksm/collection/54bbd380dc3baaa27b-EVRLOOT?search=Reinforced%20Palm%20Rod

vikiival commented 10 months ago

anyway, when I search "Reinforced Palm Rod" on singular they show only "439 results"

Yes because they hide some items

https://singular.app/collectibles/kusama/54bbd380dc3baaa27b-EVRLOOT/14983235-54bbd380dc3baaa27b-EVRLOOT-ADVANCED_FISHINGROD-00003220

We have 4/5 cards like this

Screenshot 2023-08-10 at 13 40 53
preschian commented 10 months ago

how to hide it in our query? currently this is our query where: {burned_eq: false, AND: $search} seems like it's better if we can hide it

without query, the total items in that collection: singular -> 4314 items our UI -> 4360 items

vikiival commented 10 months ago

how to hide it in our query? currently this is our query where: {burned_eq: false, AND: $search} seems like it's better if we can hide it

as the smart man (@preschian) said:

there is no meta.image or resources from the indexer

{
  "data": {
    "nftEntityById": {
      "meta": {
        "name": "Reinforced Palm Rod",
        "image": null,
        "animationUrl": null
      }
    }
  }
}

So dumb approach is to hide it on frontend, Numbers won't be 100% correct Till fetching via TokenEntity is not implemented

preschian commented 10 months ago

ok, I think it's better to wait TokenEntity implemented then