search

kodadot / rubick

Implementation SubSquid indexer for Kusama NFTs
https://github.com/kodadot/rubick
9 stars 15 forks source link

RMRK 2.0 changes #60

Open vikiival opened 2 years ago

vikiival commented 2 years ago

https://github.com/kodadot/nft-gallery/pull/2910

https://github.com/rmrk-team/rmrk-tools/blob/530223d0da9a4fb2b7e2f6b9fb82e545ae988cf1/src/rmrk2.0.0/tools/types.ts#L40

roiLeo commented 2 years ago

https://github.com/ma-shulgin/rmrk2-integration

vikiival commented 2 years ago

Brutal find @roiLeo !

yangwao commented 2 years ago

Should we use it tho ? Maybe ask SubSquid folks if they are aware of any other rmrk2 implementation?

On Tue, Jun 21, 2022 at 2:14 PM Viki Val @.***> wrote:

Brutal find @roiLeo https://github.com/roiLeo !

— Reply to this email directly, view it on GitHub https://github.com/kodadot/rubick/issues/60#issuecomment-1161667535, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM5PON3M36SCYMGRN7SZOLVQGW2LANCNFSM5UPZMMNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

vikiival commented 2 years ago

Should we use it tho ?

It's possible to extract the good parts and integrate into rubick

vikiival commented 2 years ago

This would be most probably two migrations :)

1. Have a compatibility layer for RMRK 2.0 NFTs which are not composable

2. ~ Rest

Ref:

roiLeo commented 2 years ago

Hey! are we going to fork rmrk2-integration project and create a new endpoint?

vikiival commented 2 years ago

create a new endpoint?

The best would be to have it under the one repository. Not sure if there are some incompatible changes except new interactions

vikiival commented 2 years ago

So.

with a lot of changes we will release it as rubick@008