kode-team / easylogic.studio

Fantastic Web Design Tool
https://editor.easylogic.studio
MIT License
494 stars 54 forks source link

Adding icon with object selected does not move #129

Closed Correct-Syntax closed 3 years ago

Correct-Syntax commented 3 years ago

Screenshot 2021-06-09 110657

If an object is selected when adding an icon from the left panel, when I go to move it, the blue border moves but not the icon (in the above image the "comment" icon should be moved where the blue border widget thing is.

easylogic commented 3 years ago

hi @Correct-Syntax

Thanks for reporting.

To verify this, I need some information.

Can you check the browser you are using and if there are any script errors?

Correct-Syntax commented 3 years ago

This is on Firefox (the latest)

Errors: console-export-2021-6-9_13-5-57.txt

Important note: it seems this is only a problem when the Layout is set to GRID

easylogic commented 3 years ago

I am checking the error code you showed.

I'll check some more and let you know.

easylogic commented 3 years ago

@Correct-Syntax

I released new version.

Please try it to test. (https://editor.easylogic.studio)

Correct-Syntax commented 3 years ago

Screenshot 2021-06-13 173938

Still seems to be an issue.

Exact steps:

  1. Select default rectangle and set layout to GRID
  2. Add icon from "Library"
  3. Try to move the icon

The only error is:

Uncaught (in promise) TypeError: this.el.getAttribute is not a function
    value https://editor.easylogic.studio/editor.js?32db23a777e4b47937eb:1
    value https://editor.easylogic.studio/editor.js?32db23a777e4b47937eb:1
    value https://editor.easylogic.studio/editor.js?32db23a777e4b47937eb:330
    value https://editor.easylogic.studio/editor.js?32db23a777e4b47937eb:1
easylogic commented 3 years ago

hi @Correct-Syntax

This is a matter of the functionality of the editor itself. It may look like a bug.

The grid layout itself subordinates child items to their parent.

That's why, in fact, it becomes impossible to move by dragging.

However, there is a problem that selection must be maintained as it is.

I need to think a bit more about usability.

Correct-Syntax commented 3 years ago

Okay. Yes, I had that thought, but it would seem like a bug to an unsuspecting user. 😆

I think it would be better if the selection just didn't move at all like you said.

easylogic commented 3 years ago

hi @Correct-Syntax

Layout items are prevented from moving after selection.

please test it again.

Correct-Syntax commented 3 years ago

Much better now 👍

easylogic commented 3 years ago

Good.

If you need any features, please let me know. I will do my best to make it.

easylogic commented 3 years ago

hi @Correct-Syntax.

I'd love to hear your impressions of using the tool.

I think this will help a lot in determining the direction the tool should go.

Correct-Syntax commented 3 years ago

Hi @easylogic,

While this is a neat project, I haven't really actually used it too much so I am not sure how well my feedback would be. I mostly use Sketch for Windows in my real and hobby work since I am familiar with it.

It's not really clear, but does this project intend to replace Sketch? I think you had mentioned it was something similar.

Just a laundry-list of features and improvements that would be nice (just based on my fiddling around with the editor):

Also, I have considered helping with the project, but I would really prefer to work with Vue.js...so maybe you could convert the project into a Vue.js based one rather than vanilla js? (Easier said than done, of course...!)

easylogic commented 3 years ago

hi @Correct-Syntax

Thank you so much for your comments.

I will try to reflect it as much as possible.

It is right that the goal of the tool itself is to become a professional design tool like sketch or figma.

But I guess I'm still in the experimental stage.

And now I'm getting ready to put the editor in the form of a component elsewhere as well. So I think I will be able to make a wrapper for vuejs in the near future.