search

kode54 / Game_Music_Emu

Game Music Emu - Multi-purpose console music emulator and player library
80 stars 16 forks source link

Could not replay Sangokushi 2 - Haou no Tairiku #14

Closed wmjordan closed 5 years ago

wmjordan commented 6 years ago

I came from Droidsound, which used GME as one of its plugin.

The GME module could not replay the following NSFE file, which could be replayed with NotSoFatso on Windows with the following setting:

Ignore Illegal=1

Is it possible to add support for this game music?

Sangokushi 2 - Haou no Tairiku (EMU).zophar.zip

kode54 commented 6 years ago

That needs to be re-ripped. It should not be trying to execute opcodes which could have unpredictable effects. Stopping the core from executing undocumented opcodes which do have predictable, if unusual effects, is not as simple as inserting a switch into the player. And what if a rip actually requires these instructions to play?

wmjordan commented 6 years ago

Thank you for replying.

Very unfortunately, I don't know how to reach the ripper. And ripping an NSF is not so easy at all. Enabling that music to be played, although theoretically could miss some "instructions", is still better than hearing nothing at all.

Furthermore, I have not encounter another file which requires that option. Only this one, and this one sound quite right on NotSo Fatso, with the Ignore Illegal option on.

That file has been on Zophar for more than 10 years. Nobody else had provided another rip for that game. Maybe re-ripping that piece is a very tough task--much tougher than enabling the Ignore Illegal switch.

wmjordan commented 5 years ago

Someone has posted a fix for that NSF file here: https://github.com/SourMesen/Mesen/issues/43

I applied the fix to the file and it was playable then. Sangokushi.2.-.Haou.no.Tairiku.EMU.zophar.zip