search

kodecocodes / swiftui-example-app-koober

Porting the example app from our Advanced iOS App Architecture book from UIKit to SwiftUI.
59 stars 11 forks source link

Views for iPhone X #19

Open kelvinlauKL opened 5 years ago

kelvinlauKL commented 5 years ago

Brief

The app has non-optimal iPhone X layout, as depicted in the screenshot in #17

Just ran into a tip in the "Building Custom Views with SwiftUI" WWDC talk that should alleviate this:

.edgesIgnoringSafeArea(:)

RCacheaux commented 5 years ago

👍 let's take care of this once we assemble all the UI views together so we can figure out where this modifier is best applied. I haven't built the intuition for this quite yet, but I think it'll be easier to figure it out once we've built out the UI hierarchy. I think we might only need to set this once (or a few times) towards to top of the view hierarchy.

kelvinlauKL commented 5 years ago

Going to leave this here for easy referencing later!