kodefox / infra

KodeFox Product Infrastructure
MIT License
12 stars 11 forks source link

chore(exoflex): Upgrade package `@react-native-community/datetimepicker` & `react-native-modal-datetime-picker` #716

Closed StefanusChristian closed 1 year ago

StefanusChristian commented 1 year ago

Changes:

The headerTextIOS changes was due to breaking changes in react-native-modal-datetime-picker: v12.0.0. Link Issue: https://github.com/mmazzarolo/react-native-modal-datetime-picker/releases/tag/v12.0.0 Solution: https://github.com/mmazzarolo/react-native-modal-datetime-picker/pull/607

StefanusChristian commented 1 year ago

It seems we have a problem in our circleci compare url orb, making the job failed without even running the test. After Josh (@ikusa) do some debugging, he told me it isn't worth pursuing this problem and better migrate this into github action.

Since this is an urgent matter (DBO Needed this changes), I'm putting the succeeded local test in here as a prove this PR is ready to be merged and address the github action migration in separate PR

https://github.com/kodefox/infra/assets/25154563/e71fb2f5-c4f4-4054-b300-c4273f443a26

ikusa commented 1 year ago

More background on the migrate suggestion

We met a bug here where the path-filter which is an orb / package on circleci to run job based on file change throw exit code 1. This path filter are forked of god know who hosted on yoan circleci. I tried to take a look of what CircleCi offer for dynamic job run and turns out bit more complicated as we need config splitting to support this kind of process.

Several reason why I think it's reasonable to move

  1. it's far far easier to do on GitHub Action
  2. we want to move generally as a company to only GitHub Action to avoid paying 2 providers
  3. The job definition are short and the migration would only take a day or two at worst case

Based on those reasoning I suggest we move from CircleCI