search

kodehomie / learn-fast-java-web-app

"Learn Fast" is a java web application for mentors and mentees that need social connection and learning management solutions.
Other
0 stars 0 forks source link

Peer Review #4

Open subu250 opened 2 years ago

subu250 commented 2 years ago

Design/Code Review 1

Project: Learn Fast: Java Web Application

Developer: Justin Hoang

Reviewer: Subheksha Karki

Item | Considerations | Comments/Suggestions -- | -- | --   |   | Reviewer comments and suggestions go here. Each item should have at least one "kudos" and two suggestions for improvement Problem Statement | 1. Accurately describes project purpose2. Is professional and free of typos, slang, etc.3. Fully explains the problem and the solution4. Is understandable by the average person |  Project objectives are well described and also explain problem and solution in the design documentation which is easy to understand.It is described a way to connect Mentors and mentees in efficient management system while learning material. I think more workflows/ diagram help to work smooth. Great project idea. Design Documentation | 1. Navigation/flow through the application is logical and easy to use.2. The order in which values are displayed are logical and easy to understand/use3. The order in which the form fields entered are logical and easy to understand/use4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens |  Design Documentation feedback is that application flow is very easy to understand with well designed as per the documentation and user stories and application flow. It is a very interesting application with new technologies. Great ideas. Data model/Database | 1. Everything on the screens and problem statement/flow is represented in the model2. There is at least one 1-to-many relationship.3. The model represents good database design |   Application flow which is represented in the problem statement is defined clearly. Database designed explains the functionality of the application as well May be need more relationships between the classes and I think all are in progress right now. Great work. Code | 1. Proper Maven project structure is used2. a .gitignore file for IntelliJ Java projects has been implemented3. There is not any redundant or copy/paste code in the JSPs or classes4. Classes are appropriately-sized (no monster classes)Property files are used appropriately: no hard-coded values5. Logging statements are used rather than System.out.println and printStackTrace.6. There are appropriate unit tests/code coverage. |  Maven Project structure is used in IntelliJ with JSPs, classes and there is no redundant or copy/paste code. Appropriate classes are used. Logging statements used in code is in progress. Great start on the project.
pawaitemadisoncollege commented 2 years ago

@subu250 @mybffjustin Some sneaky printlns are hanging about. An easy way to search for those: https://github.com/mybffjustin/learn-fast-java-web-app/search?q=print