Week 8 ready for review

kodehomie / learn-fast-java-web-app

"Learn Fast" is a java web application for mentors and mentees that need social connection and learning management solutions.

Other

0 stars 0 forks source link

Week 8 ready for review #5

Open kodehomie opened 2 years ago

kodehomie commented 2 years ago

@pawaitemadisoncollege week 8 is complete

What were your key learning points/takeaways?

My key learning points are SOAP, REST, JAX-RS, Jackson, and consuming web services.

What challenged you?

Figuring out how to use JavaMail challenged me this week. It seems like sometimes I break a few things adding in a new thing. This makes me wonder if I should have things designed more isolated or if I am having other issues.

What problems did you solve and what resources did you use to solve them?

One problem I solved this week was consuming and unit testing JavaMail, but I still have an issue of securing the application. I am able to send mail, but google indicates a security issue like in the screenshot. Overall a great week of learning and I am looking forward to learning new things about Java during spring break.

kodehomie commented 2 years ago

javamail-Screenshot 2022-03-12 232218

kodehomie commented 2 years ago

JavaMail-API-Test

pawaitemadisoncollege commented 2 years ago

Hi @mybffjustin - congratulations on getting the javamail api implemented in your application! Having email capability in your project takes this to the next level!

For the week 8 exercise, the goal was to consume a RESTful api and write unit tests to verify it's working properly (similar to Week 8 Activity 3). I don't think the JavaMail API is a RESTful api? http://paulawaite.com/education/java113/Module2/Week8/Exercise.html.

Also curious if you have unit tests for the javamail api? I was not sure if I was looking in the correct branch, as I didn't see any unit tests yet.

kodehomie commented 2 years ago

Thank you, @pawaitemadisoncollege I now included Programming Quotes Rest API from https://programming-quotes-api.herokuapp.com/index.html with unit tests. I made another solution for JavaMail with unit testing; I forgot to bring my old JavaMail files from my other branch before. ProgrammingQuotes-REST-API-Test .

pawaitemadisoncollege commented 2 years ago

Hey @mybffjustin! What a fun api you found!

Excellent attention to the detail and "doing it right" here: https://github.com/mybffjustin/learn-fast-java-web-app/blob/13ea93810ed10f25d0f3a62a2970ca54c44cedf6/src/main/java/org/justinhoang/persistence/ProQuoteDao.java#L32-L33. Often, developers hard-code values like the uri into programs, thinking we'll fix it later, and that rarely happens (or we end up scrambling to polish things late in the game). Kudos for getting it right early!

[ ] For a real application implementation, it might make sense to grab a random quote with this uri, https://programming-quotes-api.herokuapp.com/quotes/random, rather than hard-coding the id in. Unit testing for the random quote could verify that some quote was returned, without verifying the exact text.

You've been working really hard this semester and it shows!