pawaitemadisoncollege
commented
2 years ago Nice job hitting Checkpoint 2, @mybffjustin! Lots of good stuff here like the spring framework and Lombok! Wow!
I had a few questions and observations as I was reviewing:
-
[ ] It looks like you have a number of classes and interfaces related to hibernate and jpa data access objects. With the generic version of the hibernate dao, is the UserDao and related User* classes in the persistence package necessary? In the FatBikeTrailReports demo application, you can see an example of using a generic dao so that no other daos are necessary in the application. Curious if that is the ultimate goal here as well?
-
[ ] In the PropLoader interface, would it make sense to throw the exception so that exceptions aren't lost here: https://github.com/mybffjustin/learn-fast-java-web-app/blob/13ea93810ed10f25d0f3a62a2970ca54c44cedf6/src/main/java/org/justinhoang/util/PropLoader.java#L18-L20
-
[ ] Have you considered taking some time to javadoc the code? As prospective employers examine this code base as part of your portfolio, it will help them to understand the structure and purpose of each class and method. It would help me too - as I am currently a little confused about the number of classes in the persistence package, for example.
-
[ ] Is the project plan up-to-date?
kodehomie
@pawaitemadisoncollege - checkpoint 2 is ready for review