search

kodeine / laravel-acl

Light-weight role-based permissions system for Laravel 6+ built in Auth system.
MIT License
787 stars 217 forks source link

Laravel 6.0 Support #235

Closed alec-joy closed 4 years ago

alec-joy commented 4 years ago

Breaks compatibility with previous versions of Laravel and PHP versions before 7.0 (though Laravel 6 requires 7.2)

kodeine commented 4 years ago

awesome, let me review this

kodeine commented 4 years ago

looks like we got test errors.

alec-joy commented 4 years ago

The publishMigrations method on master was (rightly) changed to loadMigrations, I just got rid of it all together to use the new method of migration loading described here

I should have pulled master before making changes, that's on me haha. I was working off the 1.0 branch.

kodeine commented 4 years ago

lol no worries, as soon tests pass, we'll be good to go with merge! thank you for your time and efforts.

alec-joy commented 4 years ago

Awesome, do you have any interest in tagging releases for the 1.0 and tagging this as 2.0? I can update the readme to indicate the break/which version to use for which laravel, just need to know what to put in the installation field

kodeine commented 4 years ago

yup that would be perfect! please do so.