search

kodemore / kink

Dependency injection container made for Python
MIT License
397 stars 25 forks source link

allow for explicit None to be set #19

Closed gsherman81 closed 2 years ago

dkraczkowski commented 2 years ago

@gsherman81 Hello, thanks for your contribution. Would you be so kind and please add description to this PR? Description should contain a short explanation of what kind of problem this PR resolves and provide possible use-case scenario. Thank you.

gsherman81 commented 2 years ago

Yes and I will fix failing tests too

On Mon, Oct 25, 2021, 4:59 PM Dawid Kraczkowski @.***> wrote:

@gsherman81 https://github.com/gsherman81 Hello, thanks for your contribution. Would you be so kind and please add description in the PR, what kind of problem this PR resolves and provide possible use-case scenario? Thank you.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kodemore/kink/pull/19#issuecomment-951325739, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABP4WK6PDFJASMASD5R4Z3LUIXAMVANCNFSM5GVPWURQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

dkraczkowski commented 2 years ago

I put this PR in draft for now, until we get meaningful description of a problem, which this PR tries to solve.

dkraczkowski commented 2 years ago

Closing PR due to inactivity.