kodepandai / laravel-indonesia

Laravel package for Indonesia administrative data.
https://packagist.org/packages/kodepandai/laravel-indonesia
MIT License
6 stars 4 forks source link

Enhance: add domain configuration #3

Open lakuapik opened 1 year ago

lakuapik commented 1 year ago

Currently we do not support domain in api config, would be nice to have.

lakuapik commented 1 year ago

@axmad386 would you mind help us do this? haha

axmad386 commented 1 year ago

@lakuapik I don't get it. How custom domains are needed in this package. It's kodepandai/laravel-indonesia. Did you mean to add this issue to kodepandai/laravel-api-response?

lakuapik commented 1 year ago

currently we have an open api, can be configured here https://github.com/kodepandai/laravel-indonesia/blob/master/config/indonesia.php, it would be nice if we have on option to set domain name since we can configure the path and prefix.

https://laravel.test => main website https://api.laravel.test/api/indonesia => api endpoint